[Lldb-commits] [lldb] [llvm] [AArch64][llvm] Tighten SYSP parsing; don't disassemble invalid encodings (PR #182410)

[via lldb-commits]

================
@@ -894,10 +900,11 @@ bool AArch64InstPrinter::printRangePrefetchAlias(const MCInst *MI,
 
 bool AArch64InstPrinter::printSysAlias(const MCInst *MI,
                                        const MCSubtargetInfo &STI,
-                                       raw_ostream &O) {
+                                       raw_ostream &O, bool PairOperand) {
 #ifndef NDEBUG
   unsigned Opcode = MI->getOpcode();
-  assert(Opcode == AArch64::SYSxt && "Invalid opcode for SYS alias!");
+  assert((Opcode == AArch64::SYSxt || Opcode == AArch64::SYSPxt) &&
----------------
Lukacma wrote:

I think we either keep all the logic into printSyspAlias or we try to see how much of the common code we can extract from printSyspAlias printSysAlias and printSyslAlias and keep that as a separate function called by all 3. I don't think it is good idea to merge printers here

https://github.com/llvm/llvm-project/pull/182410