[Lldb-commits] [lldb] [lldb][NFC] Remove unused parameters in IRForTarget helpers (PR #195200)
Alex Langford via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 30 17:07:07 PDT 2026
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/195200
These parameters are unused.
>From 348db040e52a0d10cb290d9ed4ce3d78be4a06e6 Mon Sep 17 00:00:00 2001
From: Alex Langford <alangford at apple.com>
Date: Thu, 30 Apr 2026 17:05:39 -0700
Subject: [PATCH] [lldb][NFC] Remove extra parameters in IRForTarget helpers
These parameters are unused.
---
.../ExpressionParser/Clang/IRForTarget.cpp | 21 ++++++++-----------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp b/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
index 49f8f4fd5581e..e537f76c4ed89 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
@@ -83,23 +83,21 @@ IRForTarget::IRForTarget(lldb_private::ClangExpressionDeclMap *decl_map,
/* Handy utility functions used at several places in the code */
-static std::string PrintValue(const Value *value, bool truncate = false) {
+static std::string PrintValue(const Value *value) {
+ if (!value)
+ return {};
std::string s;
- if (value) {
- raw_string_ostream rso(s);
- value->print(rso);
- if (truncate)
- s.resize(s.length() - 1);
- }
+ raw_string_ostream rso(s);
+ value->print(rso);
return s;
}
-static std::string PrintType(const llvm::Type *type, bool truncate = false) {
+static std::string PrintType(const llvm::Type *type) {
+ if (!type)
+ return {};
std::string s;
raw_string_ostream rso(s);
type->print(rso);
- if (truncate)
- s.resize(s.length() - 1);
return s;
}
@@ -214,8 +212,7 @@ bool IRForTarget::CreateResultVariable(llvm::Function &llvm_function) {
return false;
}
- LLDB_LOG(log, "Found result in the IR: \"{0}\"",
- PrintValue(result_value, false));
+ LLDB_LOG(log, "Found result in the IR: \"{0}\"", PrintValue(result_value));
GlobalVariable *result_global = dyn_cast<GlobalVariable>(result_value);
More information about the lldb-commits
mailing list