[Lldb-commits] [lldb] [LLDB][Part 1] Support enabling/disabling InstrumentationRuntime plugins in an debug session (PR #193328)

[Jonas Devlieghere via lldb-commits]

================
@@ -246,7 +312,16 @@ List only the plugin 'foo' matching a fully qualified name exactly
   }
 
   void OutputTextFormat(const std::vector<llvm::StringRef> &patterns,
-                        CommandReturnObject &result) {
+                        CommandReturnObject &result,
+                        Debugger &requesting_debugger,
+                        PluginDomainKind domain) {
+    if (domain != PluginDomainKind::ePluginDomainKindGlobal) {
+      result.AppendErrorWithFormatv(
+          "{} domain is not supported",
+          PluginManager::PluginDomainKindToStr(domain));
+      return;
+    }
----------------
JDevlieghere wrote:

Can we hoist this into `DoExecute` and instead `assert` here to avoid the duplication between `OutputJsonFormat` and `OutputTextFormat`?

https://github.com/llvm/llvm-project/pull/193328