[Lldb-commits] [lldb] [LLDB] Include qualified setting name in apropos search (PR #194873)

[David Spickett via lldb-commits]

================
@@ -462,32 +462,71 @@ void OptionValueProperties::DumpAllDescriptions(CommandInterpreter &interpreter,
   }
 }
 
+// This function flattens a nested set of properties. This is what we want for
+// search results. If we didn't do this, search results would be presented
+// split up by type of setting.
----------------
DavidSpickett wrote:

Example of the split:
```
'platform.plugin.qemu-user' variables:

  architecture      -- Architecture to emulate.
  emulator-args     -- Extra arguments to pass to the emulator.
  emulator-env-vars -- Extra variables to add to the emulator environment.
  emulator-path     -- Path to the emulator binary. If the path does not contain a directory separator, the filename is looked up in the PATH environment variable. If empty, the filename is
                       derived from the architecture setting.
  target-env-vars   -- Extra variables to add to emulated target environment.

'platform.plugin.wasm' variables:

  port-arg     -- Argument to the WebAssembly runtime to specify the GDB remote port. The port number chosen by LLDB will be concatenated to this argument. For example: `-g=127.0.0.1:` or
                  `--debugger-port `.
  runtime-args -- Extra arguments to pass to the WebAssembly runtime. For the argument that specifies the GDB remote port, use port-arg instead.
  runtime-path -- Path to the WebAssembly runtime binary. If the path does not contain a directory separator, the filename is looked up in the PATH environment variable.
```
Which is pretty cool overall but not good for search results because it makes it harder to see where your search term has been found.

https://github.com/llvm/llvm-project/pull/194873