[Lldb-commits] [lldb] [lldb][NFC] Move BreakpointSite::IsEnabled/SetEnabled into Process (PR #192964)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -1587,6 +1586,16 @@ Status Process::EnableBreakpointSiteByID(lldb::user_id_t break_id) {
   return error;
 }
 
+bool Process::IsBreakpointSiteEnabled(const lldb::BreakpointSiteSP &site) {
+  assert(site);
+  return site->m_enabled;
+}
+
+bool Process::IsBreakpointSiteEnabled(BreakpointSite *site) {
+  assert(site);
+  return site->m_enabled;
+}
----------------
felipepiovezan wrote:

Ah, I've just remembered why. The subsequent PR changes this method to query the delayed cache, which stores shared pointers.... so this would have saved one "shared_from_this" call.

But to be fair this is not a good justification, so let's keep it as a reference.

https://github.com/llvm/llvm-project/pull/192964