[Lldb-commits] [lldb] [lldb] Fix has_lldb_codesign check (PR #194412)
Sergei Druzhkov via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 27 09:59:02 PDT 2026
https://github.com/DrSergei updated https://github.com/llvm/llvm-project/pull/194412
>From ec5c63c84feadab99ca0876138ad56e8e68a37c6 Mon Sep 17 00:00:00 2001
From: Sergei Druzhkov <serzhdruzhok at gmail.com>
Date: Mon, 27 Apr 2026 19:21:38 +0300
Subject: [PATCH 1/2] [lldb] Fix has_lldb_codesign check
---
lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py b/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py
index 002343ab8c8ff..e270d3579eea4 100644
--- a/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py
+++ b/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py
@@ -10,6 +10,8 @@
def has_lldb_codesign():
"""Check if the lldb_codesign certificate is available."""
try:
+ if lldbplatformutil.getPlatform() not in lldbplatformutil.getDarwinOSTriples():
+ return False
result = subprocess.run(
[
"security",
>From 1f50252f06f9a283792cf66aa2d34defb17199d7 Mon Sep 17 00:00:00 2001
From: Sergei Druzhkov <serzhdruzhok at gmail.com>
Date: Mon, 27 Apr 2026 19:57:45 +0300
Subject: [PATCH 2/2] Fix review comments
---
lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py b/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py
index e270d3579eea4..bceef9ee27ea6 100644
--- a/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py
+++ b/lldb/test/API/macosx/dsym_codesign/TestdSYMCodesign.py
@@ -1,6 +1,7 @@
import os
import shutil
import subprocess
+import sys
import lldb
from lldbsuite.test.decorators import *
@@ -10,7 +11,7 @@
def has_lldb_codesign():
"""Check if the lldb_codesign certificate is available."""
try:
- if lldbplatformutil.getPlatform() not in lldbplatformutil.getDarwinOSTriples():
+ if sys.platform != "darwin":
return False
result = subprocess.run(
[
More information about the lldb-commits
mailing list