[Lldb-commits] [lldb] Ensure that the Synthetic children of a ValueObject are managed by their parents ClusterManager (PR #192561)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 16 15:48:11 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- lldb/include/lldb/DataFormatters/TypeSynthetic.h lldb/include/lldb/Target/Target.h lldb/include/lldb/ValueObject/ValueObject.h lldb/include/lldb/ValueObject/ValueObjectConstResult.h lldb/source/API/SBValue.cpp lldb/source/DataFormatters/TypeSynthetic.cpp lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp lldb/source/Plugins/Language/CPlusPlus/GenericInitializerList.cpp lldb/source/Plugins/Language/CPlusPlus/GenericList.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp lldb/source/Plugins/Language/CPlusPlus/LibStdcppSpan.cpp lldb/source/Plugins/Language/CPlusPlus/MsvcStlDeque.cpp lldb/source/Plugins/Language/CPlusPlus/MsvcStlSpan.cpp lldb/source/Plugins/Language/CPlusPlus/MsvcStlVector.cpp lldb/source/Plugins/Language/ObjC/NSArray.cpp lldb/source/Plugins/Language/ObjC/NSDictionary.cpp lldb/source/Plugins/Language/ObjC/NSError.cpp lldb/source/Plugins/Language/ObjC/NSException.cpp lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp lldb/source/Plugins/Language/ObjC/NSSet.cpp lldb/source/Plugins/Language/ObjC/NSString.cpp lldb/source/Target/Target.cpp lldb/source/ValueObject/ValueObject.cpp lldb/source/ValueObject/ValueObjectConstResult.cpp lldb/source/ValueObject/ValueObjectConstResultImpl.cpp lldb/source/ValueObject/ValueObjectSynthetic.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lldb/include/lldb/DataFormatters/TypeSynthetic.h b/lldb/include/lldb/DataFormatters/TypeSynthetic.h
index c2348e03b..ae44d7e8f 100644
--- a/lldb/include/lldb/DataFormatters/TypeSynthetic.h
+++ b/lldb/include/lldb/DataFormatters/TypeSynthetic.h
@@ -89,18 +89,17 @@ public:
protected:
lldb::ValueObjectSP
CreateChildValueObjectFromExpression(llvm::StringRef name,
- llvm::StringRef expression,
- const ExecutionContext &exe_ctx);
+ llvm::StringRef expression,
+ const ExecutionContext &exe_ctx);
lldb::ValueObjectSP
CreateChildValueObjectFromAddress(llvm::StringRef name, uint64_t address,
- const ExecutionContext &exe_ctx,
- CompilerType type, bool do_deref = true);
+ const ExecutionContext &exe_ctx,
+ CompilerType type, bool do_deref = true);
- lldb::ValueObjectSP CreateChildValueObjectFromData(llvm::StringRef name,
- const DataExtractor &data,
- const ExecutionContext &exe_ctx,
- CompilerType type);
+ lldb::ValueObjectSP CreateChildValueObjectFromData(
+ llvm::StringRef name, const DataExtractor &data,
+ const ExecutionContext &exe_ctx, CompilerType type);
private:
SyntheticChildrenFrontEnd(const SyntheticChildrenFrontEnd &) = delete;
diff --git a/lldb/include/lldb/Target/Target.h b/lldb/include/lldb/Target/Target.h
index 8fdf5bbdd..3a257b7e2 100644
--- a/lldb/include/lldb/Target/Target.h
+++ b/lldb/include/lldb/Target/Target.h
@@ -284,9 +284,9 @@ public:
void SetDebugUtilityExpression(bool debug);
bool GetDebugUtilityExpression() const;
-
+
void SetCheckValueObjectOwnership(bool check);
-
+
bool GetCheckValueObjectOwnership() const;
std::optional<LoadScriptFromSymFile>
diff --git a/lldb/include/lldb/ValueObject/ValueObject.h b/lldb/include/lldb/ValueObject/ValueObject.h
index d9e63ff38..2ca1c6009 100644
--- a/lldb/include/lldb/ValueObject/ValueObject.h
+++ b/lldb/include/lldb/ValueObject/ValueObject.h
@@ -712,47 +712,37 @@ public:
/// use the method CreateChildValueObjectFrom... instead for that purpose.
/// That will ensure the right parent is passed in.
- static lldb::ValueObjectSP
- CreateValueObjectFromExpression(llvm::StringRef name,
- llvm::StringRef expression,
- const ExecutionContext &exe_ctx,
- ValueObject *parent = nullptr);
+ static lldb::ValueObjectSP CreateValueObjectFromExpression(
+ llvm::StringRef name, llvm::StringRef expression,
+ const ExecutionContext &exe_ctx, ValueObject *parent = nullptr);
- static lldb::ValueObjectSP
- CreateValueObjectFromExpression(llvm::StringRef name,
- llvm::StringRef expression,
- const ExecutionContext &exe_ctx,
- const EvaluateExpressionOptions &options,
- ValueObject *parent = nullptr);
+ static lldb::ValueObjectSP CreateValueObjectFromExpression(
+ llvm::StringRef name, llvm::StringRef expression,
+ const ExecutionContext &exe_ctx, const EvaluateExpressionOptions &options,
+ ValueObject *parent = nullptr);
/// Given an address either create a value object containing the value at
/// that address, or create a value object containing the address itself
/// (pointer value), depending on whether the parameter 'do_deref' is true or
/// false.
- static lldb::ValueObjectSP
- CreateValueObjectFromAddress(llvm::StringRef name, uint64_t address,
- const ExecutionContext &exe_ctx,
- CompilerType type, bool do_deref = true,
- ValueObject *parent = nullptr);
+ static lldb::ValueObjectSP CreateValueObjectFromAddress(
+ llvm::StringRef name, uint64_t address, const ExecutionContext &exe_ctx,
+ CompilerType type, bool do_deref = true, ValueObject *parent = nullptr);
static lldb::ValueObjectSP
CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType type,
- ValueObject *parent = nullptr);
+ ValueObject *parent = nullptr);
/// Create a value object containing the given APInt value.
- static lldb::ValueObjectSP
- CreateValueObjectFromAPInt(const ExecutionContext &exe_ctx,
- const llvm::APInt &v, CompilerType type,
- llvm::StringRef name,
- ValueObject *parent = nullptr);
+ static lldb::ValueObjectSP CreateValueObjectFromAPInt(
+ const ExecutionContext &exe_ctx, const llvm::APInt &v, CompilerType type,
+ llvm::StringRef name, ValueObject *parent = nullptr);
/// Create a value object containing the given APFloat value.
- static lldb::ValueObjectSP
- CreateValueObjectFromAPFloat(const ExecutionContext &exe_ctx,
- const llvm::APFloat &v, CompilerType type,
- llvm::StringRef name,
- ValueObject *parent = nullptr);
+ static lldb::ValueObjectSP CreateValueObjectFromAPFloat(
+ const ExecutionContext &exe_ctx, const llvm::APFloat &v,
+ CompilerType type, llvm::StringRef name, ValueObject *parent = nullptr);
/// Create a value object containing the given Scalar value.
static lldb::ValueObjectSP
@@ -761,11 +751,9 @@ public:
ValueObject *parent = nullptr);
/// Create a value object containing the given boolean value.
- static lldb::ValueObjectSP
- CreateValueObjectFromBool(const ExecutionContext &exe_ctx,
- lldb::TypeSystemSP typesystem, bool value,
- llvm::StringRef name,
- ValueObject *parent = nullptr);
+ static lldb::ValueObjectSP CreateValueObjectFromBool(
+ const ExecutionContext &exe_ctx, lldb::TypeSystemSP typesystem,
+ bool value, llvm::StringRef name, ValueObject *parent = nullptr);
/// Create a nullptr value object with the specified type (must be a
/// nullptr type).
@@ -776,12 +764,12 @@ public:
/// These are the appropriate routines to make a ValueObject that get managed
/// by this ValueObject (and all the other members of its Cluster).
- lldb::ValueObjectSP
- CreateChildValueObjectFromExpression(llvm::StringRef name,
- llvm::StringRef expression,
- const ExecutionContext &exe_ctx,
- const EvaluateExpressionOptions &options) {
- return CreateValueObjectFromExpression(name, expression, exe_ctx, options, this);
+ lldb::ValueObjectSP CreateChildValueObjectFromExpression(
+ llvm::StringRef name, llvm::StringRef expression,
+ const ExecutionContext &exe_ctx,
+ const EvaluateExpressionOptions &options) {
+ return CreateValueObjectFromExpression(name, expression, exe_ctx, options,
+ this);
}
/// Given an address either create a value object containing the value at
@@ -790,45 +778,46 @@ public:
/// false.
lldb::ValueObjectSP
CreateChildValueObjectFromAddress(llvm::StringRef name, uint64_t address,
- const ExecutionContext &exe_ctx,
- CompilerType type, bool do_deref = true) {
- return CreateValueObjectFromAddress(name, address, exe_ctx, type, do_deref, this);
+ const ExecutionContext &exe_ctx,
+ CompilerType type, bool do_deref = true) {
+ return CreateValueObjectFromAddress(name, address, exe_ctx, type, do_deref,
+ this);
}
- lldb::ValueObjectSP
- CreateChildValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
- const ExecutionContext &exe_ctx, CompilerType type) {
+ lldb::ValueObjectSP CreateChildValueObjectFromData(
+ llvm::StringRef name, const DataExtractor &data,
+ const ExecutionContext &exe_ctx, CompilerType type) {
return CreateValueObjectFromData(name, data, exe_ctx, type, this);
}
/// Create a value object containing the given APInt value.
lldb::ValueObjectSP
CreateChildValueObjectFromAPInt(const ExecutionContext &exe_ctx,
- const llvm::APInt &v, CompilerType type,
- llvm::StringRef name) {
+ const llvm::APInt &v, CompilerType type,
+ llvm::StringRef name) {
return CreateValueObjectFromAPInt(exe_ctx, v, type, name, this);
}
/// Create a value object containing the given APFloat value.
lldb::ValueObjectSP
CreateChildValueObjectFromAPFloat(const ExecutionContext &exe_ctx,
- const llvm::APFloat &v, CompilerType type,
- llvm::StringRef name) {
+ const llvm::APFloat &v, CompilerType type,
+ llvm::StringRef name) {
return CreateValueObjectFromAPFloat(exe_ctx, v, type, name, this);
}
/// Create a value object containing the given Scalar value.
lldb::ValueObjectSP
CreateChildValueObjectFromScalar(const ExecutionContext &exe_ctx, Scalar &s,
- CompilerType type, llvm::StringRef name) {
+ CompilerType type, llvm::StringRef name) {
return CreateValueObjectFromScalar(exe_ctx, s, type, name, this);
}
/// Create a value object containing the given boolean value.
lldb::ValueObjectSP
CreateChildValueObjectFromBool(const ExecutionContext &exe_ctx,
- lldb::TypeSystemSP typesystem, bool value,
- llvm::StringRef name) {
+ lldb::TypeSystemSP typesystem, bool value,
+ llvm::StringRef name) {
return CreateValueObjectFromBool(exe_ctx, typesystem, value, name, this);
}
@@ -836,7 +825,7 @@ public:
/// nullptr type).
lldb::ValueObjectSP
CreateChildValueObjectFromNullptr(const ExecutionContext &exe_ctx,
- CompilerType type, llvm::StringRef name) {
+ CompilerType type, llvm::StringRef name) {
return CreateValueObjectFromNullptr(exe_ctx, type, name, this);
}
@@ -973,7 +962,7 @@ public:
/// pointing to, and thus also can't know its size. See the comment in
/// Value::m_value for a more thorough explanation of why that is.
llvm::ArrayRef<uint8_t> GetLocalBuffer() const;
-
+
lldb::ValueObjectSP CheckValueObjectOwnership(ValueObject *child);
protected:
@@ -1019,7 +1008,7 @@ protected:
ChildrenMap m_children;
size_t m_children_count = 0;
};
-
+
// Classes that inherit from ValueObject can see and modify these
/// The parent value object, or nullptr if this has no parent.
diff --git a/lldb/include/lldb/ValueObject/ValueObjectConstResult.h b/lldb/include/lldb/ValueObject/ValueObjectConstResult.h
index 1ddea2bc8..f10753095 100644
--- a/lldb/include/lldb/ValueObject/ValueObjectConstResult.h
+++ b/lldb/include/lldb/ValueObject/ValueObjectConstResult.h
@@ -35,16 +35,17 @@ class ValueObjectConstResult : public ValueObject {
public:
~ValueObjectConstResult() override;
- static lldb::ValueObjectSP
- Create(ExecutionContextScope *exe_scope, lldb::ByteOrder byte_order,
- uint32_t addr_byte_size, lldb::addr_t address = LLDB_INVALID_ADDRESS,
- ValueObjectManager *manager = nullptr);
+ static lldb::ValueObjectSP Create(ExecutionContextScope *exe_scope,
+ lldb::ByteOrder byte_order,
+ uint32_t addr_byte_size,
+ lldb::addr_t address = LLDB_INVALID_ADDRESS,
+ ValueObjectManager *manager = nullptr);
- static lldb::ValueObjectSP
- Create(ExecutionContextScope *exe_scope, const CompilerType &compiler_type,
- ConstString name, const DataExtractor &data,
- lldb::addr_t address = LLDB_INVALID_ADDRESS,
- ValueObjectManager *manager = nullptr);
+ static lldb::ValueObjectSP Create(ExecutionContextScope *exe_scope,
+ const CompilerType &compiler_type,
+ ConstString name, const DataExtractor &data,
+ lldb::addr_t address = LLDB_INVALID_ADDRESS,
+ ValueObjectManager *manager = nullptr);
static lldb::ValueObjectSP
Create(ExecutionContextScope *exe_scope, const CompilerType &compiler_type,
@@ -53,12 +54,10 @@ public:
lldb::addr_t address = LLDB_INVALID_ADDRESS,
ValueObjectManager *manager = nullptr);
- static lldb::ValueObjectSP Create(ExecutionContextScope *exe_scope,
- const CompilerType &compiler_type,
- ConstString name, lldb::addr_t address,
- AddressType address_type,
- uint32_t addr_byte_size,
- ValueObjectManager *manager = nullptr);
+ static lldb::ValueObjectSP
+ Create(ExecutionContextScope *exe_scope, const CompilerType &compiler_type,
+ ConstString name, lldb::addr_t address, AddressType address_type,
+ uint32_t addr_byte_size, ValueObjectManager *manager = nullptr);
static lldb::ValueObjectSP Create(ExecutionContextScope *exe_scope,
Value &value, ConstString name,
diff --git a/lldb/source/API/SBValue.cpp b/lldb/source/API/SBValue.cpp
index 8fbcecb49..4ee8b271c 100644
--- a/lldb/source/API/SBValue.cpp
+++ b/lldb/source/API/SBValue.cpp
@@ -456,8 +456,8 @@ lldb::SBValue SBValue::CreateValueFromAddress(const char *name,
if (value_sp && type_impl_sp) {
CompilerType ast_type(type_impl_sp->GetCompilerType(true));
ExecutionContext exe_ctx(value_sp->GetExecutionContextRef());
- new_value_sp = value_sp->CreateChildValueObjectFromAddress(name, address,
- exe_ctx, ast_type);
+ new_value_sp = value_sp->CreateChildValueObjectFromAddress(
+ name, address, exe_ctx, ast_type);
}
sb_value.SetSP(new_value_sp);
return sb_value;
@@ -508,8 +508,8 @@ lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) {
"cannot get a type system: {0}");
return {};
}
- return value_sp->CreateChildValueObjectFromBool(exe_ctx, *type_system_or_err,
- value, name);
+ return value_sp->CreateChildValueObjectFromBool(
+ exe_ctx, *type_system_or_err, value, name);
};
sb_value.SetSP(get_new_value());
return sb_value;
diff --git a/lldb/source/DataFormatters/TypeSynthetic.cpp b/lldb/source/DataFormatters/TypeSynthetic.cpp
index afcb75ef5..5c6bccd50 100644
--- a/lldb/source/DataFormatters/TypeSynthetic.cpp
+++ b/lldb/source/DataFormatters/TypeSynthetic.cpp
@@ -129,18 +129,20 @@ SyntheticChildrenFrontEnd::CalculateNumChildrenIgnoringErrors(uint32_t max) {
return 0;
}
-lldb::ValueObjectSP SyntheticChildrenFrontEnd::CreateChildValueObjectFromExpression(
+lldb::ValueObjectSP
+SyntheticChildrenFrontEnd::CreateChildValueObjectFromExpression(
llvm::StringRef name, llvm::StringRef expression,
const ExecutionContext &exe_ctx) {
EvaluateExpressionOptions options;
- ValueObjectSP valobj_sp = m_backend.CreateChildValueObjectFromExpression(name,
- expression, exe_ctx, options);
+ ValueObjectSP valobj_sp = m_backend.CreateChildValueObjectFromExpression(
+ name, expression, exe_ctx, options);
if (valobj_sp)
valobj_sp->SetSyntheticChildrenGenerated(true);
return valobj_sp;
}
-lldb::ValueObjectSP SyntheticChildrenFrontEnd::CreateChildValueObjectFromAddress(
+lldb::ValueObjectSP
+SyntheticChildrenFrontEnd::CreateChildValueObjectFromAddress(
llvm::StringRef name, uint64_t address, const ExecutionContext &exe_ctx,
CompilerType type, bool do_deref) {
ValueObjectSP valobj_sp = m_backend.CreateChildValueObjectFromAddress(
@@ -153,8 +155,8 @@ lldb::ValueObjectSP SyntheticChildrenFrontEnd::CreateChildValueObjectFromAddress
lldb::ValueObjectSP SyntheticChildrenFrontEnd::CreateChildValueObjectFromData(
llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType type) {
- ValueObjectSP valobj_sp =
- m_backend.CreateChildValueObjectFromData(name, data, exe_ctx, type);
+ ValueObjectSP valobj_sp =
+ m_backend.CreateChildValueObjectFromData(name, data, exe_ctx, type);
if (valobj_sp)
valobj_sp->SetSyntheticChildrenGenerated(true);
return valobj_sp;
diff --git a/lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp b/lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp
index d10c307b5..3a8b44dff 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp
@@ -126,8 +126,8 @@ ValueObjectSP GenericBitsetFrontEnd::GetChildAtIndex(uint32_t idx) {
uint8_t value = !!(chunk->GetValueAsUnsigned(0) & (uint64_t(1) << chunk_idx));
DataExtractor data(&value, sizeof(value), m_byte_order, m_byte_size);
- m_elements[idx] = CreateChildValueObjectFromData(llvm::formatv("[{0}]", idx).str(),
- data, ctx, m_bool_type);
+ m_elements[idx] = CreateChildValueObjectFromData(
+ llvm::formatv("[{0}]", idx).str(), data, ctx, m_bool_type);
return m_elements[idx];
}
diff --git a/lldb/source/Plugins/Language/CPlusPlus/GenericInitializerList.cpp b/lldb/source/Plugins/Language/CPlusPlus/GenericInitializerList.cpp
index 9d5eed384..fd8b0ec08 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/GenericInitializerList.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/GenericInitializerList.cpp
@@ -89,8 +89,8 @@ public:
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState Update() override {
diff --git a/lldb/source/Plugins/Language/CPlusPlus/GenericList.cpp b/lldb/source/Plugins/Language/CPlusPlus/GenericList.cpp
index 1f93d8a24..269592afd 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/GenericList.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/GenericList.cpp
@@ -329,8 +329,8 @@ ValueObjectSP LibCxxForwardListFrontEnd::GetChildAtIndex(uint32_t idx) {
return nullptr;
return CreateChildValueObjectFromData(llvm::formatv("[{0}]", idx).str(), data,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState LibCxxForwardListFrontEnd::Update() {
@@ -434,8 +434,8 @@ lldb::ValueObjectSP LibCxxListFrontEnd::GetChildAtIndex(uint32_t idx) {
lldb::addr_t addr = current_sp->GetParent()->GetPointerValue().address;
addr = addr + 2 * process_sp->GetAddressByteSize();
ExecutionContext exe_ctx(process_sp);
- current_sp =
- CreateChildValueObjectFromAddress("__value_", addr, exe_ctx, m_element_type);
+ current_sp = CreateChildValueObjectFromAddress("__value_", addr, exe_ctx,
+ m_element_type);
if (!current_sp)
return lldb::ValueObjectSP();
}
@@ -451,8 +451,8 @@ lldb::ValueObjectSP LibCxxListFrontEnd::GetChildAtIndex(uint32_t idx) {
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromData(name.GetString(), data,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState LibCxxListFrontEnd::Update() {
@@ -520,8 +520,8 @@ ValueObjectSP MsvcStlForwardListFrontEnd::GetChildAtIndex(uint32_t idx) {
return nullptr;
return CreateChildValueObjectFromData(llvm::formatv("[{0}]", idx).str(), data,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState MsvcStlForwardListFrontEnd::Update() {
@@ -591,8 +591,8 @@ lldb::ValueObjectSP MsvcStlListFrontEnd::GetChildAtIndex(uint32_t idx) {
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromData(name.GetString(), data,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState MsvcStlListFrontEnd::Update() {
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp
index bb99c876b..b0a46be18 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxProxyArray.cpp
@@ -123,8 +123,8 @@ lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "] -> [%zu]", (uint64_t)idx, value);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp
index 647f1401f..c1d59d317 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxSliceArray.cpp
@@ -111,8 +111,8 @@ lldb_private::formatters::LibcxxStdSliceArraySyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp
index 3d3ebfbc2..498c8994e 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp
@@ -88,8 +88,8 @@ lldb_private::formatters::LibcxxStdSpanSyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
index 91af6d44e..ed02a212d 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp
@@ -211,7 +211,7 @@ lldb::ValueObjectSP lldb_private::formatters::
ExecutionContext exe_ctx =
val_hash->GetExecutionContextRef().Lock(thread_and_frame_only_if_stopped);
return CreateChildValueObjectFromData(stream.GetString(), data, exe_ctx,
- m_element_type);
+ m_element_type);
}
llvm::Expected<size_t>
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp
index 06eba08ea..fbac15b4f 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxValarray.cpp
@@ -92,8 +92,8 @@ lldb_private::formatters::LibcxxStdValarraySyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
index f9a6df245..95d12e8ee 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp
@@ -122,8 +122,8 @@ lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
static ValueObjectSP GetDataPointer(ValueObject &root) {
diff --git a/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp b/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
index 2f0a4fb66..64175d96b 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
@@ -144,7 +144,7 @@ LibstdcppMapIteratorSyntheticFrontEnd::GetChildAtIndex(uint32_t idx) {
if (m_pair_address != 0 && m_pair_type) {
if (!m_pair_sp)
m_pair_sp = CreateChildValueObjectFromAddress("pair", m_pair_address,
- m_exe_ctx_ref, m_pair_type);
+ m_exe_ctx_ref, m_pair_type);
if (m_pair_sp)
return m_pair_sp->GetChildAtIndex(idx);
}
diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlDeque.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlDeque.cpp
index 381e6b118..b8c2205af 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlDeque.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlDeque.cpp
@@ -87,8 +87,8 @@ lldb_private::formatters::MsvcStlDequeSyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), second_address,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSpan.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSpan.cpp
index 4db6b1e67..30f5b2f4c 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSpan.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSpan.cpp
@@ -61,8 +61,8 @@ lldb_private::formatters::MsvcStlSpanSyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVector.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVector.cpp
index 7a31d69c3..0a611d181 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVector.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlVector.cpp
@@ -108,8 +108,8 @@ lldb_private::formatters::MsvcStlVectorSyntheticFrontEnd::GetChildAtIndex(
StreamString name;
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(name.GetString(), offset,
- m_backend.GetExecutionContextRef(),
- m_element_type);
+ m_backend.GetExecutionContextRef(),
+ m_element_type);
}
lldb::ChildCacheState
diff --git a/lldb/source/Plugins/Language/ObjC/NSArray.cpp b/lldb/source/Plugins/Language/ObjC/NSArray.cpp
index 90e83445c..f87cf459f 100644
--- a/lldb/source/Plugins/Language/ObjC/NSArray.cpp
+++ b/lldb/source/Plugins/Language/ObjC/NSArray.cpp
@@ -486,7 +486,7 @@ lldb_private::formatters::NSArrayMSyntheticFrontEndBase::GetChildAtIndex(
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(idx_name.GetString(), object_at_idx,
- m_exe_ctx_ref, m_id_type);
+ m_exe_ctx_ref, m_id_type);
}
template <typename D32, typename D64>
@@ -663,7 +663,7 @@ lldb_private::formatters::GenericNSArrayISyntheticFrontEnd<D32, D64, Inline>::
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
return CreateChildValueObjectFromAddress(idx_name.GetString(), object_at_idx,
- m_exe_ctx_ref, m_id_type);
+ m_exe_ctx_ref, m_id_type);
}
lldb_private::formatters::NSArray0SyntheticFrontEnd::NSArray0SyntheticFrontEnd(
diff --git a/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp b/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
index 26e28b5e7..5699b6215 100644
--- a/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
+++ b/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
@@ -690,8 +690,8 @@ lldb_private::formatters::NSDictionaryISyntheticFrontEnd::GetChildAtIndex(
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
DataExtractor data(buffer_sp, m_order, m_ptr_size);
- dict_item.valobj_sp = CreateChildValueObjectFromData(idx_name.GetString(), data,
- m_exe_ctx_ref, m_pair_type);
+ dict_item.valobj_sp = CreateChildValueObjectFromData(
+ idx_name.GetString(), data, m_exe_ctx_ref, m_pair_type);
}
return dict_item.valobj_sp;
}
@@ -813,8 +813,8 @@ lldb_private::formatters::NSCFDictionarySyntheticFrontEnd::GetChildAtIndex(
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
DataExtractor data(buffer_sp, m_order, m_ptr_size);
- dict_item.valobj_sp = CreateChildValueObjectFromData(idx_name.GetString(), data,
- m_exe_ctx_ref, m_pair_type);
+ dict_item.valobj_sp = CreateChildValueObjectFromData(
+ idx_name.GetString(), data, m_exe_ctx_ref, m_pair_type);
}
return dict_item.valobj_sp;
}
@@ -916,8 +916,8 @@ lldb::ValueObjectSP lldb_private::formatters::
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
DataExtractor data(buffer_sp, m_order, m_ptr_size);
- dict_item.valobj_sp = CreateChildValueObjectFromData(idx_name.GetString(), data,
- m_exe_ctx_ref, m_pair_type);
+ dict_item.valobj_sp = CreateChildValueObjectFromData(
+ idx_name.GetString(), data, m_exe_ctx_ref, m_pair_type);
}
return dict_item.valobj_sp;
}
@@ -1141,8 +1141,8 @@ lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
DataExtractor data(buffer_sp, m_order, m_ptr_size);
- dict_item.valobj_sp = CreateChildValueObjectFromData(idx_name.GetString(), data,
- m_exe_ctx_ref, m_pair_type);
+ dict_item.valobj_sp = CreateChildValueObjectFromData(
+ idx_name.GetString(), data, m_exe_ctx_ref, m_pair_type);
}
return dict_item.valobj_sp;
}
@@ -1277,8 +1277,8 @@ lldb_private::formatters::Foundation1100::
StreamString idx_name;
idx_name.Printf("[%" PRIu64 "]", (uint64_t)idx);
DataExtractor data(buffer_sp, m_order, m_ptr_size);
- dict_item.valobj_sp = CreateChildValueObjectFromData(idx_name.GetString(), data,
- m_exe_ctx_ref, m_pair_type);
+ dict_item.valobj_sp = CreateChildValueObjectFromData(
+ idx_name.GetString(), data, m_exe_ctx_ref, m_pair_type);
}
return dict_item.valobj_sp;
}
diff --git a/lldb/source/Plugins/Language/ObjC/NSException.cpp b/lldb/source/Plugins/Language/ObjC/NSException.cpp
index 725aca416..b874559e5 100644
--- a/lldb/source/Plugins/Language/ObjC/NSException.cpp
+++ b/lldb/source/Plugins/Language/ObjC/NSException.cpp
@@ -118,8 +118,8 @@ static bool ExtractFields(ValueObject &valobj, ValueObjectSP *name_sp,
bool lldb_private::formatters::NSException_SummaryProvider(
ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) {
lldb::ValueObjectSP reason_sp;
- if (!ExtractFields(valobj, nullptr, &reason_sp, nullptr, nullptr,
- /*owned_by_valobj=*/ false))
+ if (!ExtractFields(valobj, nullptr, &reason_sp, nullptr, nullptr,
+ /*owned_by_valobj=*/false))
return false;
if (!reason_sp) {
@@ -163,7 +163,7 @@ public:
const auto ret = ExtractFields(m_backend, &m_name_sp, &m_reason_sp,
&m_userinfo_sp, &m_reserved_sp,
- /*owned_by_valobj=*/ true);
+ /*owned_by_valobj=*/true);
return ret ? lldb::ChildCacheState::eReuse
: lldb::ChildCacheState::eRefetch;
diff --git a/lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp b/lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp
index 70316c4f1..f0bf65461 100644
--- a/lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp
+++ b/lldb/source/Plugins/Language/ObjC/NSIndexPath.cpp
@@ -162,7 +162,6 @@ protected:
struct InlinedIndexes {
public:
-
void SetIndexes(uint64_t value, Process &p) {
m_indexes = value;
_lengthForInlinePayload(p.GetAddressByteSize());
diff --git a/lldb/source/ValueObject/ValueObject.cpp b/lldb/source/ValueObject/ValueObject.cpp
index 638cd1e06..6007e0d6d 100644
--- a/lldb/source/ValueObject/ValueObject.cpp
+++ b/lldb/source/ValueObject/ValueObject.cpp
@@ -381,13 +381,11 @@ ValueObjectSP ValueObject::CheckValueObjectOwnership(ValueObject *child) {
if (GetTargetSP()->GetCheckValueObjectOwnership()) {
// Child value objects should always be owned by their parent's manager.
if (child && (child->GetManager() != GetManager())) {
- Status error =
- Status::FromErrorStringWithFormatv(
- "ValueObject: '{0}' not owned by its parent: '{1}'",
- child->GetName(), GetName());
- ValueObjectSP ret_sp =
- ValueObjectConstResult::Create(GetTargetSP().get(), std::move(error),
- this->GetManager());
+ Status error = Status::FromErrorStringWithFormatv(
+ "ValueObject: '{0}' not owned by its parent: '{1}'", child->GetName(),
+ GetName());
+ ValueObjectSP ret_sp = ValueObjectConstResult::Create(
+ GetTargetSP().get(), std::move(error), this->GetManager());
return ret_sp;
}
}
@@ -3539,14 +3537,11 @@ SymbolContextScope *ValueObject::GetSymbolContextScope() {
return nullptr;
}
-lldb::ValueObjectSP
-ValueObject::CreateValueObjectFromExpression(llvm::StringRef name,
- llvm::StringRef expression,
- const ExecutionContext &exe_ctx,
- ValueObject *parent) {
+lldb::ValueObjectSP ValueObject::CreateValueObjectFromExpression(
+ llvm::StringRef name, llvm::StringRef expression,
+ const ExecutionContext &exe_ctx, ValueObject *parent) {
return CreateValueObjectFromExpression(name, expression, exe_ctx,
- EvaluateExpressionOptions(),
- parent);
+ EvaluateExpressionOptions(), parent);
}
lldb::ValueObjectSP ValueObject::CreateValueObjectFromExpression(
@@ -3585,7 +3580,7 @@ lldb::ValueObjectSP ValueObject::CreateValueObjectFromAddress(
lldb::ValueObjectSP ptr_result_valobj_sp(ValueObjectConstResult::Create(
exe_ctx.GetBestExecutionContextScope(), pointer_type,
ConstString(name), buffer, exe_ctx.GetByteOrder(),
- exe_ctx.GetAddressByteSize(), /*address=*/ LLDB_INVALID_ADDRESS,
+ exe_ctx.GetAddressByteSize(), /*address=*/LLDB_INVALID_ADDRESS,
parent ? parent->GetManager() : nullptr));
if (ptr_result_valobj_sp) {
if (do_deref)
@@ -3616,11 +3611,9 @@ lldb::ValueObjectSP ValueObject::CreateValueObjectFromData(
return new_value_sp;
}
-lldb::ValueObjectSP
-ValueObject::CreateValueObjectFromAPInt(const ExecutionContext &exe_ctx,
- const llvm::APInt &v, CompilerType type,
- llvm::StringRef name,
- ValueObject *parent) {
+lldb::ValueObjectSP ValueObject::CreateValueObjectFromAPInt(
+ const ExecutionContext &exe_ctx, const llvm::APInt &v, CompilerType type,
+ llvm::StringRef name, ValueObject *parent) {
uint64_t byte_size =
llvm::expectedToOptional(
type.GetByteSize(exe_ctx.GetBestExecutionContextScope()))
@@ -3628,31 +3621,28 @@ ValueObject::CreateValueObjectFromAPInt(const ExecutionContext &exe_ctx,
lldb::DataExtractorSP data_sp = std::make_shared<DataExtractor>(
reinterpret_cast<const void *>(v.getRawData()), byte_size,
exe_ctx.GetByteOrder(), exe_ctx.GetAddressByteSize());
- return ValueObject::CreateValueObjectFromData(name, *data_sp, exe_ctx, type, parent);
+ return ValueObject::CreateValueObjectFromData(name, *data_sp, exe_ctx, type,
+ parent);
}
lldb::ValueObjectSP ValueObject::CreateValueObjectFromAPFloat(
const ExecutionContext &exe_ctx, const llvm::APFloat &v, CompilerType type,
llvm::StringRef name, ValueObject *parent) {
- return CreateValueObjectFromAPInt(exe_ctx, v.bitcastToAPInt(), type, name, parent);
+ return CreateValueObjectFromAPInt(exe_ctx, v.bitcastToAPInt(), type, name,
+ parent);
}
-lldb::ValueObjectSP
-ValueObject::CreateValueObjectFromScalar(const ExecutionContext &exe_ctx,
- Scalar &s, CompilerType type,
- llvm::StringRef name,
- ValueObject *parent) {
- return ValueObjectConstResult::Create(exe_ctx.GetBestExecutionContextScope(),
- type, s, ConstString(name),
- /*module_ptr=*/ nullptr,
- parent ? parent->GetManager() : nullptr);
+lldb::ValueObjectSP ValueObject::CreateValueObjectFromScalar(
+ const ExecutionContext &exe_ctx, Scalar &s, CompilerType type,
+ llvm::StringRef name, ValueObject *parent) {
+ return ValueObjectConstResult::Create(
+ exe_ctx.GetBestExecutionContextScope(), type, s, ConstString(name),
+ /*module_ptr=*/nullptr, parent ? parent->GetManager() : nullptr);
}
-lldb::ValueObjectSP
-ValueObject::CreateValueObjectFromBool(const ExecutionContext &exe_ctx,
- TypeSystemSP typesystem_sp, bool value,
- llvm::StringRef name,
- ValueObject *parent) {
+lldb::ValueObjectSP ValueObject::CreateValueObjectFromBool(
+ const ExecutionContext &exe_ctx, TypeSystemSP typesystem_sp, bool value,
+ llvm::StringRef name, ValueObject *parent) {
CompilerType type = typesystem_sp->GetBasicTypeFromAST(lldb::eBasicTypeBool);
ExecutionContextScope *exe_scope = exe_ctx.GetBestExecutionContextScope();
uint64_t byte_size =
@@ -3660,7 +3650,8 @@ ValueObject::CreateValueObjectFromBool(const ExecutionContext &exe_ctx,
lldb::DataExtractorSP data_sp = std::make_shared<DataExtractor>(
reinterpret_cast<const void *>(&value), byte_size, exe_ctx.GetByteOrder(),
exe_ctx.GetAddressByteSize());
- return ValueObject::CreateValueObjectFromData(name, *data_sp, exe_ctx, type, parent);
+ return ValueObject::CreateValueObjectFromData(name, *data_sp, exe_ctx, type,
+ parent);
}
lldb::ValueObjectSP ValueObject::CreateValueObjectFromNullptr(
@@ -3678,7 +3669,8 @@ lldb::ValueObjectSP ValueObject::CreateValueObjectFromNullptr(
lldb::DataExtractorSP data_sp = std::make_shared<DataExtractor>(
reinterpret_cast<const void *>(zero), byte_size, exe_ctx.GetByteOrder(),
exe_ctx.GetAddressByteSize());
- return ValueObject::CreateValueObjectFromData(name, *data_sp, exe_ctx, type, parent);
+ return ValueObject::CreateValueObjectFromData(name, *data_sp, exe_ctx, type,
+ parent);
}
ModuleSP ValueObject::GetModule() {
diff --git a/lldb/source/ValueObject/ValueObjectConstResult.cpp b/lldb/source/ValueObject/ValueObjectConstResult.cpp
index e8f17f96f..1620e9b45 100644
--- a/lldb/source/ValueObject/ValueObjectConstResult.cpp
+++ b/lldb/source/ValueObject/ValueObjectConstResult.cpp
@@ -65,8 +65,8 @@ ValueObjectSP ValueObjectConstResult::Create(ExecutionContextScope *exe_scope,
manager_sp = ValueObjectManager::Create();
manager = manager_sp.get();
}
- return (new ValueObjectConstResult(exe_scope, *manager, compiler_type,
- name, data, address))
+ return (new ValueObjectConstResult(exe_scope, *manager, compiler_type, name,
+ data, address))
->GetSP();
}
@@ -92,22 +92,19 @@ ValueObjectConstResult::ValueObjectConstResult(
SetAddressTypeOfChildren(eAddressTypeLoad);
}
-ValueObjectSP ValueObjectConstResult::Create(ExecutionContextScope *exe_scope,
- const CompilerType &compiler_type,
- ConstString name,
- const lldb::DataBufferSP &data_sp,
- lldb::ByteOrder data_byte_order,
- uint32_t data_addr_size,
- lldb::addr_t address,
- ValueObjectManager *manager) {
+ValueObjectSP ValueObjectConstResult::Create(
+ ExecutionContextScope *exe_scope, const CompilerType &compiler_type,
+ ConstString name, const lldb::DataBufferSP &data_sp,
+ lldb::ByteOrder data_byte_order, uint32_t data_addr_size,
+ lldb::addr_t address, ValueObjectManager *manager) {
std::shared_ptr<ValueObjectManager> manager_sp;
if (!manager) {
manager_sp = ValueObjectManager::Create();
manager = manager_sp.get();
}
- return (new ValueObjectConstResult(exe_scope, *manager, compiler_type,
- name, data_sp, data_byte_order,
- data_addr_size, address))
+ return (new ValueObjectConstResult(exe_scope, *manager, compiler_type, name,
+ data_sp, data_byte_order, data_addr_size,
+ address))
->GetSP();
}
@@ -120,8 +117,7 @@ ValueObjectSP ValueObjectConstResult::Create(ExecutionContextScope *exe_scope,
manager_sp = ValueObjectManager::Create();
manager = manager_sp.get();
}
- return (new ValueObjectConstResult(exe_scope, *manager, value, name,
- module))
+ return (new ValueObjectConstResult(exe_scope, *manager, value, name, module))
->GetSP();
}
@@ -135,8 +131,8 @@ ValueObjectSP ValueObjectConstResult::Create(ExecutionContextScope *exe_scope,
manager_sp = ValueObjectManager::Create();
manager = manager_sp.get();
}
- return (new ValueObjectConstResult(exe_scope, *manager, compiler_type,
- scalar, name, module))
+ return (new ValueObjectConstResult(exe_scope, *manager, compiler_type, scalar,
+ name, module))
->GetSP();
}
@@ -158,21 +154,17 @@ ValueObjectConstResult::ValueObjectConstResult(
SetAddressTypeOfChildren(eAddressTypeLoad);
}
-ValueObjectSP ValueObjectConstResult::Create(ExecutionContextScope *exe_scope,
- const CompilerType &compiler_type,
- ConstString name,
- lldb::addr_t address,
- AddressType address_type,
- uint32_t addr_byte_size,
- ValueObjectManager *manager) {
+ValueObjectSP ValueObjectConstResult::Create(
+ ExecutionContextScope *exe_scope, const CompilerType &compiler_type,
+ ConstString name, lldb::addr_t address, AddressType address_type,
+ uint32_t addr_byte_size, ValueObjectManager *manager) {
std::shared_ptr<ValueObjectManager> manager_sp;
if (!manager) {
manager_sp = ValueObjectManager::Create();
manager = manager_sp.get();
}
- return (new ValueObjectConstResult(exe_scope, *manager, compiler_type,
- name, address, address_type,
- addr_byte_size))
+ return (new ValueObjectConstResult(exe_scope, *manager, compiler_type, name,
+ address, address_type, addr_byte_size))
->GetSP();
}
@@ -207,7 +199,7 @@ ValueObjectConstResult::ValueObjectConstResult(
}
ValueObjectSP ValueObjectConstResult::Create(ExecutionContextScope *exe_scope,
- Status &&error,
+ Status &&error,
ValueObjectManager *manager) {
std::shared_ptr<ValueObjectManager> manager_sp;
diff --git a/lldb/source/ValueObject/ValueObjectConstResultImpl.cpp b/lldb/source/ValueObject/ValueObjectConstResultImpl.cpp
index fb0b5e6d0..110b6c34b 100644
--- a/lldb/source/ValueObject/ValueObjectConstResultImpl.cpp
+++ b/lldb/source/ValueObject/ValueObjectConstResultImpl.cpp
@@ -185,7 +185,8 @@ lldb::ValueObjectSP ValueObjectConstResultImpl::AddressOf(Status &error) {
m_address_of_backend = ValueObjectConstResult::Create(
exe_ctx.GetBestExecutionContextScope(), compiler_type.GetPointerType(),
ConstString(new_name.c_str()), buffer, endian::InlHostByteOrder(),
- exe_ctx.GetAddressByteSize(), LLDB_INVALID_ADDRESS, m_impl_backend->GetManager());
+ exe_ctx.GetAddressByteSize(), LLDB_INVALID_ADDRESS,
+ m_impl_backend->GetManager());
m_address_of_backend->GetValue().SetValueType(Value::ValueType::Scalar);
m_address_of_backend->GetValue().GetScalar() = m_live_address;
``````````
</details>
https://github.com/llvm/llvm-project/pull/192561
More information about the lldb-commits
mailing list