[Lldb-commits] [lldb] [lldb] Allow forks to occur in expression evaluation (PR #184815)

[via lldb-commits]

jimingham wrote:

What I was suggesting was that you go half-way back to what you were doing before.  Originally you were checking if ANY thread was running an expression when handling the fork and force following the parent in that case.  I suggested optimistically that you should really only have to check whether the expression thread was the one that forked.
As you found out, I was too optimistic.
So a good amelioration for this PR is to go back to the original "If any thread is calling a function you have to follow the parent" check, but the warning message should distinguish the two cases - the one you already have:

On follow-parent is allowed when running an expression that forks

and if another thread was running the expression

Couldn't follow-child because the fork occurred while an expression was running on another thread.

That should be pretty simple to do.

https://github.com/llvm/llvm-project/pull/184815