[Lldb-commits] [lld] [lldb] [llvm] [Support][Cache] Make `pruneCache` return an `Expected` (PR #191367)

[Chinmay Deshpande via lldb-commits]

Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?=,
Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?=,
Juan Manuel Martinez =?utf-8?q?Caama=C3=B1o?=
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/191367 at github.com>


================
@@ -274,7 +320,11 @@ Expected<std::string> getCachedOrDownloadArtifact(
         parseCachePruningPolicy(std::getenv("DEBUGINFOD_CACHE_POLICY"));
     if (!PruningPolicyOrErr)
       return PruningPolicyOrErr.takeError();
-    pruneCache(CacheDirectoryPath, *PruningPolicyOrErr);
+
+    Expected<bool> ErrOrPruned =
----------------
chinmaydd wrote:

Nit: Naming convention seems to be `RetValOrErr` (eg: `PruningPolicyOrErr`)

https://github.com/llvm/llvm-project/pull/191367