[Lldb-commits] [lld] [lldb] [llvm] [Support][Cache] Make `pruneCache` return an `Expected` (PR #191367)

[Chinmay Deshpande via lldb-commits]

Juan Manuel Martinez =?utf-8?q?Caamaño?=,
Juan Manuel Martinez =?utf-8?q?Caamaño?=,
Juan Manuel Martinez =?utf-8?q?Caamaño?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/191367 at github.com>


================
@@ -281,8 +282,7 @@ bool llvm::pruneCache(StringRef Path, CachePruningPolicy Policy,
     auto ErrOrSpaceInfo = sys::fs::disk_space(Path);
     if (!ErrOrSpaceInfo) {
       auto EC = ErrOrSpaceInfo.getError();
-      report_fatal_error(Twine("Can't get available size for '") + Path.str() +
-                         "': " + EC.message());
+      return errorCodeToError(EC);
----------------
chinmaydd wrote:

I think an improvement here to keep some context around would be

```
return createStringError(EC, "cannot get available disk space for '%s': %s",
                         Path.str().c_str(), EC.message().c_str());
```

https://github.com/llvm/llvm-project/pull/191367