[Lldb-commits] [lldb] [lldb] Add Python cryptography package as new test dependency (PR #192434)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> Do I need to patch llvm-zorg/requirements.txt manually?

No that requirements is for buildbot itself. What happens on the builders is up to their config and owners.

> Do I need to update llvm-project/.ci/all_requirements.txt manually?

Judging from the git log, yes. I assume the command at the top of the file works.

> I don't see any mention of test deps in llvm-zorg/buildbot/osuosl/master/config/builders.py Will build bots install the package automatically?

No but we could make them do that. MLIR appears to - https://github.com/llvm/llvm-zorg/blob/2c447faab8854c28a034d8cbd082e82251241ad0/zorg/buildbot/builders/UnifiedTreeBuilder.py#L290.

Somewhere in https://github.com/llvm/llvm-zorg/blob/2c447faab8854c28a034d8cbd082e82251241ad0/zorg/buildbot/builders/LLDBBuilder.py#L4 would be the place to do it.

https://github.com/llvm/llvm-project/pull/192434