[Lldb-commits] [lldb] [LLDB] Extract process arguments from core dump for Linux (PR #185338)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

I think we agree on what is being done, just some comments on the how part now.

This needs a release note. LLDB's release notes are part of https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb. There is a "Linux" section you should add a bullet point to.

You can write your own of course, but here's my attempt that you can use:
* When an ELF core file is loaded, LLDB now shows the command line that created the core file. If you need to see it again, use the command `process status -v`.

Also you said you hadn't tested this on anything but Linux, but I wonder if it would "just work(tm)" for other ELF Unix.

So I'm not asking you the author of this PR to do any more work, but @mchoo7 could you try this out in FreeBSD userspace and see what happens?

If we're lucky, it just works and we can add tests using the existing core files in another PR. If even one of them has a command in it that would be enough. We don't need to check the truncation detection as Linux has that covered.

https://github.com/llvm/llvm-project/pull/185338