[Lldb-commits] [lldb] [lldb] Add caching and _NT_SYMBOL_PATH parsing in SymbolLocatorSymStore (PR #191782)

[via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/191782 at github.com>


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 33401 tests passed
* 525 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### lldb-unit
<details>
<summary>lldb-unit.Symbol/_/SymbolTests/SymStoreTest/ParseEnvSymbolPaths_Cache</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/unittests/Symbol/./SymbolTests --gtest_filter=SymStoreTest.ParseEnvSymbolPaths_Cache
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:84
Expected equality of these values:
  check("SRV*C:\\symcache*\\\\corp\\symbols")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\symcache")
    Which is: { "C:\\symcache" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:85
Expected equality of these values:
  check("D:\\sym;srv*C:\\symcache*D:\\sym")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\symcache")
    Which is: { "C:\\symcache" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:88
Expected equality of these values:
  check("cache*D:\\s;srv*\\\\corp")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("D:\\s")
    Which is: { "D:\\s" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:90
Expected equality of these values:
  check("CACHE*D:\\s;srv*\\\\corp;SRV*http://localhost")
    Which is: { "/home/gha/.cache/lldb/symstore", "/home/gha/.cache/lldb/symstore" }
  returns("D:\\s", "D:\\s")
    Which is: { "D:\\s", "D:\\s" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:92
Expected equality of these values:
  check("Cache*D:\\s;srv*\\\\corp;SRV*C:\\X*http://localhost")
    Which is: { "/home/gha/.cache/lldb/symstore", "/home/gha/.cache/lldb/symstore" }
  returns("D:\\s", "C:\\X")
    Which is: { "D:\\s", "C:\\X" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:94
Expected equality of these values:
  check("srv*\\\\corp;cache*D:\\s;SRV*C:\\X*http://localhost")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\X")
    Which is: { "C:\\X" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:96
Expected equality of these values:
  check("srv*\\\\corp;SRV*C:\\X*http://localhost;cache*D:\\s")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\X")
    Which is: { "C:\\X" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:109
Expected equality of these values:
  check("cache*C:\\1;;D:\\sym;SRV*")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\1")
    Which is: { "C:\\1" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:111
Expected equality of these values:
  check("cache*C:\\1;srv*D:\\1*D:\\2*D:\\3;srv*D:\\sym")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\1")
    Which is: { "C:\\1" }

/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Symbol/SymStoreTest.cpp:112
Expected equality of these values:
  check("cache*C:\\1;symsrv*D:\\1;srv*D:\\sym")
    Which is: { "/home/gha/.cache/lldb/symstore" }
  returns("C:\\1")
    Which is: { "C:\\1" }


```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/191782