[Lldb-commits] [lldb] [lldb] Add caching and _NT_SYMBOL_PATH parsing in SymbolLocatorSymStore (PR #191782)

[via lldb-commits]

================
@@ -162,10 +182,44 @@ def test_http_not_found(self):
     # certs, non-HTTPS redirects, etc.
     def test_http(self):
         """
-        Check that breakpoint hits with remote SymStore.
+        Check that breakpoint resolves with remote SymStore.
         """
         exe, sym = self.build_inferior()
         with MockedSymStore(self, exe, sym) as dir:
             with HTTPServer(dir) as url:
                 self.runCmd(f"settings set plugin.symbol-locator.symstore.urls {url}")
                 self.try_breakpoint(exe, should_have_loc=True)
+
+    def test_nt_symbol_path_local(self):
+        """
+        Check that breakpoint resolves with a local SymStore path in
+        _NT_SYMBOL_PATH, and that the PDB is not copied to the cache.
+        """
+        exe, sym = self.build_inferior()
+        cache_dir = self.getBuildArtifact("cache")
+        symstore = MockedSymStore(self, exe, sym)
+        with symstore as dir:
+            self.runCmd(
+                f"settings set plugin.symbol-locator.symstore.cache {cache_dir}"
+            )
+            with NtSymbolPath(dir):
+                self.try_breakpoint(exe, should_have_loc=True)
+            self.assertFalse(any(files for _, _, files in os.walk(cache_dir)))
+
+    def test_nt_symbol_path_srv(self):
----------------
Nerixyz wrote:

Not sure if that's easy to do: Could you add a test that specifies a URL through the settings as well as the env variable?

https://github.com/llvm/llvm-project/pull/191782