[Lldb-commits] [lldb] Use `llvm::APInt` for `VariantMember` Discriminants (PR #188487)

[via lldb-commits]

Walnut356 wrote:

I'm not super familiar with LLDB's testing infrastructure 

Coincidentally, i also figured out LLDB will straight up crash trying to handle 128-bit C-style enums e.g.:

```rust
#[repr(u128]
enum LargeDiscr {
	A = 0x15141312111009080706050403020100,
	B = 1,
}
```

I'll open an issue about it since it's a whole separate thing.

> Would it be possible to add a test for this? Potentially by checking in a obj2yaml'd binary created by Rust?

I saw the tests in `lldb\unittests\SymbolFile\DWARF\DWARFASTParserClangTests.cpp`, but after fiddling with it for a few hours, I don't think I'm knowledgeable enough to write a tests that actually compiles and tests what we'd want.

FWIW it doesn't look like any other part of the Rust `VariantPart`/`VariantMember` is tested either, and all we're really doing is swapping out an int type for another int type with a larger bit width.



https://github.com/llvm/llvm-project/pull/188487