[Lldb-commits] [lldb] [lldb] [windows] Add a LLVM_FALLTHROUGH to silence warnings. NFC. (PR #191400)

[Martin Storsjö via lldb-commits]

https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/191400

>From 5b9d5df410a480ddad327e48f5ae602c394f36f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin at martin.st>
Date: Fri, 10 Apr 2026 14:42:55 +0300
Subject: [PATCH 1/2] [lldb] [windows] Add a LLVM_FALLTHROUGH to silence
 warnings. NFC.

---
 lldb/source/Host/windows/ProcessLauncherWindows.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lldb/source/Host/windows/ProcessLauncherWindows.cpp b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
index b9cc49d8c5ca5..a8c815c105727 100644
--- a/lldb/source/Host/windows/ProcessLauncherWindows.cpp
+++ b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
@@ -340,6 +340,7 @@ HANDLE ProcessLauncherWindows::GetStdioHandle(const llvm::StringRef path,
     break;
   case STDERR_FILENO:
     flags = FILE_FLAG_WRITE_THROUGH;
+    LLVM_FALLTHROUGH;
   case STDOUT_FILENO:
     access = GENERIC_WRITE;
     create = CREATE_ALWAYS;

>From d9b71209dbf32f1c11ca4b70b799ce83f5926a94 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin at martin.st>
Date: Fri, 10 Apr 2026 23:49:18 +0300
Subject: [PATCH 2/2] Use [[fallthrough]] instead of LLVM_FALLTHROUGH

---
 lldb/source/Host/windows/ProcessLauncherWindows.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Host/windows/ProcessLauncherWindows.cpp b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
index a8c815c105727..79e0faca64961 100644
--- a/lldb/source/Host/windows/ProcessLauncherWindows.cpp
+++ b/lldb/source/Host/windows/ProcessLauncherWindows.cpp
@@ -340,7 +340,7 @@ HANDLE ProcessLauncherWindows::GetStdioHandle(const llvm::StringRef path,
     break;
   case STDERR_FILENO:
     flags = FILE_FLAG_WRITE_THROUGH;
-    LLVM_FALLTHROUGH;
+    [[fallthrough]];
   case STDOUT_FILENO:
     access = GENERIC_WRITE;
     create = CREATE_ALWAYS;