[Lldb-commits] [lldb] [LLDB][ProcessFreeBSDKernelCore] Log error when creating kernel image (PR #191397)

via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 10 05:51:29 PDT 2026


https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/191397

>From 882ec21bd11f7630fe7f98f3df95080a9415bb81 Mon Sep 17 00:00:00 2001
From: ShengYi Hung <aokblast at FreeBSD.org>
Date: Fri, 10 Apr 2026 19:40:08 +0800
Subject: [PATCH 1/3] [LLDB][ProcessFreeBSDKernelCore] Log error while creating
 image

---
 .../Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index d07e38f2783f0..1844160fb6ec6 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -80,13 +80,16 @@ lldb::ProcessSP ProcessFreeBSDKernelCore::CreateInstance(
     lldb::TargetSP target_sp, ListenerSP listener_sp,
     const FileSpec *crash_file, bool can_connect) {
   ModuleSP executable = target_sp->GetExecutableModule();
+  char errbuf[_POSIX2_LINE_MAX];
   if (crash_file && !can_connect && executable) {
     kvm_t *kvm =
         kvm_open2(executable->GetFileSpec().GetPath().c_str(),
-                  crash_file->GetPath().c_str(), O_RDONLY, nullptr, nullptr);
+                  crash_file->GetPath().c_str(), O_RDONLY, errbuf, nullptr);
     if (kvm)
       return std::make_shared<ProcessFreeBSDKernelCore>(target_sp, listener_sp,
                                                         kvm, *crash_file);
+    else
+      LLDB_LOGF(GetLog(LLDBLog::Object), "FreeBSD-Kernel-Core: %s", errbuf);
   }
   return nullptr;
 }

>From 43416aa4cd4091c7718c4b7b5eb9061da20e16a9 Mon Sep 17 00:00:00 2001
From: ShengYi Hung <aokblast at FreeBSD.org>
Date: Fri, 10 Apr 2026 20:14:13 +0800
Subject: [PATCH 2/3] fixup! [LLDB][ProcessFreeBSDKernelCore] Log error while
 creating image

---
 .../Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index 1844160fb6ec6..df2c1cdb3b5bd 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -89,7 +89,7 @@ lldb::ProcessSP ProcessFreeBSDKernelCore::CreateInstance(
       return std::make_shared<ProcessFreeBSDKernelCore>(target_sp, listener_sp,
                                                         kvm, *crash_file);
     else
-      LLDB_LOGF(GetLog(LLDBLog::Object), "FreeBSD-Kernel-Core: %s", errbuf);
+      LLDB_LOGF(GetLog(LLDBLog::Process), "FreeBSD-Kernel-Core: %s", errbuf);
   }
   return nullptr;
 }
@@ -461,7 +461,7 @@ void ProcessFreeBSDKernelCore::PrintUnreadMessage() {
 
     if (field_found != 4) {
       LLDB_LOGF(
-          GetLog(LLDBLog::Object),
+          GetLog(LLDBLog::Process),
           "FreeBSD-Kernel-Core: Could not find all required fields for msgbuf");
       return;
     }

>From 75117d84bc3bc580305645b608b208ba6b993b5b Mon Sep 17 00:00:00 2001
From: ShengYi Hung <aokblast at FreeBSD.org>
Date: Fri, 10 Apr 2026 20:49:46 +0800
Subject: [PATCH 3/3] fixup! [LLDB][ProcessFreeBSDKernelCore] Log error while
 creating image

---
 .../Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index df2c1cdb3b5bd..bff3075bf5811 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -461,7 +461,7 @@ void ProcessFreeBSDKernelCore::PrintUnreadMessage() {
 
     if (field_found != 4) {
       LLDB_LOGF(
-          GetLog(LLDBLog::Process),
+          GetLog(LLDBLog::Object),
           "FreeBSD-Kernel-Core: Could not find all required fields for msgbuf");
       return;
     }



More information about the lldb-commits mailing list