[Lldb-commits] [lldb] Use `llvm::APInt` for `VariantMember` Discriminants (PR #188487)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 10 05:02:10 PDT 2026


================
@@ -3834,9 +3858,14 @@ void DWARFASTParserClang::ParseRustVariantPart(
 
     m_ast.CompleteTagDeclarationDefinition(field_type);
 
-    auto name = has_discriminant
-                    ? llvm::formatv("$variant${0}", member.discr_value.value())
-                    : std::string("$variant$");
+    auto name = std::string("$variant$");
+    if (has_discriminant) {
+      // u128::MAX = 340282366920938463463374607431768211455 which is 39 digits
+      // long + 1 for null term
----------------
JDevlieghere wrote:

```suggestion
      // long + 1 for null terminator.
```

https://github.com/llvm/llvm-project/pull/188487


More information about the lldb-commits mailing list