[Lldb-commits] [lldb] [lldb/crashlog] Fix inlined frames in crashlog scripted process (PR #191132)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h,c -- lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/inline_test.c lldb/include/lldb/Target/StackFrameList.h lldb/source/Plugins/Process/scripted/ScriptedThread.cpp lldb/source/Target/StackFrameList.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Process/scripted/ScriptedThread.cpp b/lldb/source/Plugins/Process/scripted/ScriptedThread.cpp
index 939c18999..c8790d245 100644
--- a/lldb/source/Plugins/Process/scripted/ScriptedThread.cpp
+++ b/lldb/source/Plugins/Process/scripted/ScriptedThread.cpp
@@ -282,8 +282,8 @@ bool ScriptedThread::LoadArtificialStackFrames() {
     frame_list_idx++;
 
     // Synthesize inline frames, mirroring StackFrameList::FetchFramesUpTo().
-    frame_list_idx +=
-        frames->SynthesizeInlineFrames(synth_frame_sp, /*cfa=*/LLDB_INVALID_ADDRESS);
+    frame_list_idx += frames->SynthesizeInlineFrames(
+        synth_frame_sp, /*cfa=*/LLDB_INVALID_ADDRESS);
   }
 
   return true;
diff --git a/lldb/source/Target/StackFrameList.cpp b/lldb/source/Target/StackFrameList.cpp
index 6f663db1a..fb3d0c5f3 100644
--- a/lldb/source/Target/StackFrameList.cpp
+++ b/lldb/source/Target/StackFrameList.cpp
@@ -400,15 +400,14 @@ void StackFrameList::SynthesizeTailCallFrames(StackFrame &next_frame) {
 
 uint32_t StackFrameList::SynthesizeInlineFrames(StackFrameSP frame_sp,
                                                 addr_t cfa) {
-  SymbolContext unwind_sc = frame_sp->GetSymbolContext(
-      eSymbolContextBlock | eSymbolContextFunction);
+  SymbolContext unwind_sc =
+      frame_sp->GetSymbolContext(eSymbolContextBlock | eSymbolContextFunction);
   if (!unwind_sc.block)
     return 0;
 
   TargetSP target_sp = m_thread.CalculateTarget();
   uint32_t concrete_frame_idx = frame_sp->GetConcreteFrameIndex();
-  Address curr_frame_address(
-      frame_sp->GetFrameCodeAddressForSymbolication());
+  Address curr_frame_address(frame_sp->GetFrameCodeAddressForSymbolication());
 
   SymbolContext next_frame_sc;
   Address next_frame_address;

``````````

</details>


https://github.com/llvm/llvm-project/pull/191132