[Lldb-commits] [lldb] 9e8ea56 - [lldb] Fix flaky test TestFrameProviderThreadFilter on Windows (#191133)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 9 06:05:57 PDT 2026
Author: Dmitry Vasilyev
Date: 2026-04-09T17:05:52+04:00
New Revision: 9e8ea5677f1c85bea98ddeca9240e1fccf2f1537
URL: https://github.com/llvm/llvm-project/commit/9e8ea5677f1c85bea98ddeca9240e1fccf2f1537
DIFF: https://github.com/llvm/llvm-project/commit/9e8ea5677f1c85bea98ddeca9240e1fccf2f1537.diff
LOG: [lldb] Fix flaky test TestFrameProviderThreadFilter on Windows (#191133)
This is the update for #191046.
Added:
Modified:
lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
Removed:
################################################################################
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
index 348af4c215041..0cb3a7462ad10 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
@@ -12,8 +12,14 @@ void thread_work() {
--g_barrier;
while (g_barrier.load() > 0)
;
- std::this_thread::sleep_for(
- std::chrono::seconds(1)); // avoid timeout on Windows
+#ifdef _WIN32
+ // Avoid a timeout on Windows.
+ // It seems the debugger needs some time
+ // to init the breakpoint for the thread.
+ // This test is flaky on Windows with 1 sec sleep.
+ // Moving the break comment below did not help.
+ std::this_thread::sleep_for(std::chrono::seconds(3));
+#endif
while (g_spin) // break in thread
std::this_thread::yield();
}
More information about the lldb-commits
mailing list