[Lldb-commits] [lldb] [llvm] [Support] Remove address-extraction methods from DataExtractor (NFC) (PR #190519)

[Sergei Barannikov via lldb-commits]

================
@@ -80,22 +80,26 @@ class DataExtractor {
   /// This constructor allows us to use data that is owned by the
   /// caller. The data must stay around as long as this object is
   /// valid.
-  DataExtractor(StringRef Data, bool IsLittleEndian, uint8_t AddressSize)
-    : Data(Data), IsLittleEndian(IsLittleEndian), AddressSize(AddressSize) {}
-  DataExtractor(ArrayRef<uint8_t> Data, bool IsLittleEndian,
-                uint8_t AddressSize)
+  DataExtractor(StringRef Data, bool IsLittleEndian)
+      : Data(Data), IsLittleEndian(IsLittleEndian) {}
+
+  DataExtractor(ArrayRef<uint8_t> Data, bool IsLittleEndian)
       : Data(StringRef(reinterpret_cast<const char *>(Data.data()),
                        Data.size())),
-        IsLittleEndian(IsLittleEndian), AddressSize(AddressSize) {}
+        IsLittleEndian(IsLittleEndian) {}
+
+  // TODO: Deprecate.
----------------
s-barannikov wrote:

Delete would be correct. Only it would be difficult to delete them right away, there are too many uses. So I thought delete uses that I can find, mark them deprecated to find the rest of uses with help of failing buildbots, then delete them for good. But I guess there isn't really a difference between deprecation and deletion -- bots will be unhappy with both.


https://github.com/llvm/llvm-project/pull/190519