[Lldb-commits] [lldb] [lldb] Remove ValueObject::CastPointerType() methods (PR #191032)

[via lldb-commits]

jimingham wrote:

Those are interesting functions.  You can construct a similar result with CreateValueObjectFromAddress but that makes ValueObjectConstResults whereas these ones create ValueObjectMemory objects.  It's often struck me as odd that we use ValueObjectConstResult when making synthetic children.  That is appropriate when you don't have a representation of the value in target memory, or when you actually want to constify the value, for instance when you want to capture the result of an expression not the memory the result of the expression currently happens to point to.

At some point, it would be good to go back and rethink this approach.

https://github.com/llvm/llvm-project/pull/191032