[Lldb-commits] [lldb] 0614200 - [lldb] Fix the TestFrameProviderThreadFilter test on Windows (#191046)

via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 8 13:21:32 PDT 2026


Author: Dmitry Vasilyev
Date: 2026-04-09T00:21:26+04:00
New Revision: 061420021a2b0dc391071a45fe7cc0360236d539

URL: https://github.com/llvm/llvm-project/commit/061420021a2b0dc391071a45fe7cc0360236d539
DIFF: https://github.com/llvm/llvm-project/commit/061420021a2b0dc391071a45fe7cc0360236d539.diff

LOG: [lldb] Fix the TestFrameProviderThreadFilter test on Windows (#191046)

This is the update for #191025.

Added: 
    

Modified: 
    lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
    lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
index 297d64b1f84e5..2744ce15db4d9 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
@@ -59,7 +59,6 @@ def register_providers(self, target):
             )
             self.assertTrue(error.Success(), f"Should register {cls}: {error}")
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_star_with_thread_filter(self):
         """
         Register EvenThreadProvider, OddThreadProvider, and UpperCaseProvider.

diff  --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
index 2f73b97846619..348af4c215041 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
@@ -1,4 +1,5 @@
 #include <atomic>
+#include <chrono>
 #include <thread>
 #include <vector>
 
@@ -11,6 +12,8 @@ void thread_work() {
   --g_barrier;
   while (g_barrier.load() > 0)
     ;
+  std::this_thread::sleep_for(
+      std::chrono::seconds(1)); // avoid timeout on Windows
   while (g_spin) // break in thread
     std::this_thread::yield();
 }


        


More information about the lldb-commits mailing list