[Lldb-commits] [lldb] [lldb] Fix the TestFrameProviderThreadFilter test on Windows (PR #191046)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 8 13:08:40 PDT 2026


https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/191046

>From c3d7704add7aea17fd6d6ddd7f6da30a6560eb10 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev <dvassiliev at accesssoftek.com>
Date: Thu, 9 Apr 2026 00:04:21 +0400
Subject: [PATCH] [lldb] Fix the TestFrameProviderThreadFilter test on Windows

This is the update for #191025.
---
 .../thread_filter/TestFrameProviderThreadFilter.py             | 1 -
 .../scripted_frame_provider/thread_filter/main.cpp             | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
index 297d64b1f84e5..2744ce15db4d9 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
@@ -59,7 +59,6 @@ def register_providers(self, target):
             )
             self.assertTrue(error.Success(), f"Should register {cls}: {error}")
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_star_with_thread_filter(self):
         """
         Register EvenThreadProvider, OddThreadProvider, and UpperCaseProvider.
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
index 2f73b97846619..348af4c215041 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
@@ -1,4 +1,5 @@
 #include <atomic>
+#include <chrono>
 #include <thread>
 #include <vector>
 
@@ -11,6 +12,8 @@ void thread_work() {
   --g_barrier;
   while (g_barrier.load() > 0)
     ;
+  std::this_thread::sleep_for(
+      std::chrono::seconds(1)); // avoid timeout on Windows
   while (g_spin) // break in thread
     std::this_thread::yield();
 }



More information about the lldb-commits mailing list