[Lldb-commits] [lldb] [lldb] Fix the TestFrameProviderThreadFilter test on Windows (PR #191046)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

<details>
<summary>Changes</summary>

This is the update for #<!-- -->191025.

---
Full diff: https://github.com/llvm/llvm-project/pull/191046.diff


2 Files Affected:

- (modified) lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py (-1) 
- (modified) lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp (+2) 


``````````diff
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
index 297d64b1f84e5..2744ce15db4d9 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/TestFrameProviderThreadFilter.py
@@ -59,7 +59,6 @@ def register_providers(self, target):
             )
             self.assertTrue(error.Success(), f"Should register {cls}: {error}")
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_star_with_thread_filter(self):
         """
         Register EvenThreadProvider, OddThreadProvider, and UpperCaseProvider.
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
index 2f73b97846619..f3611e88ceb38 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
+++ b/lldb/test/API/functionalities/scripted_frame_provider/thread_filter/main.cpp
@@ -1,4 +1,5 @@
 #include <atomic>
+#include <chrono>
 #include <thread>
 #include <vector>
 
@@ -11,6 +12,7 @@ void thread_work() {
   --g_barrier;
   while (g_barrier.load() > 0)
     ;
+  std::this_thread::sleep_for(std::chrono::seconds(1)); // avoid timeout on Windows
   while (g_spin) // break in thread
     std::this_thread::yield();
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/191046