[Lldb-commits] [lldb] [lldb] Remove ValueObject::CastPointerType() methods (PR #191032)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Sergei Barannikov (s-barannikov)

<details>
<summary>Changes</summary>

These methods have never been used since their introduction in 2011.
Commit that added them: b2dcc36c


---
Full diff: https://github.com/llvm/llvm-project/pull/191032.diff


2 Files Affected:

- (modified) lldb/include/lldb/ValueObject/ValueObject.h (-6) 
- (modified) lldb/source/ValueObject/ValueObject.cpp (-27) 


``````````diff
diff --git a/lldb/include/lldb/ValueObject/ValueObject.h b/lldb/include/lldb/ValueObject/ValueObject.h
index cf69a713f1366..5476a4a89e5b1 100644
--- a/lldb/include/lldb/ValueObject/ValueObject.h
+++ b/lldb/include/lldb/ValueObject/ValueObject.h
@@ -643,12 +643,6 @@ class ValueObject {
 
   virtual lldb::ValueObjectSP DoCast(const CompilerType &compiler_type);
 
-  virtual lldb::ValueObjectSP CastPointerType(const char *name,
-                                              CompilerType &ast_type);
-
-  virtual lldb::ValueObjectSP CastPointerType(const char *name,
-                                              lldb::TypeSP &type_sp);
-
   /// Return the target load address associated with this value object.
   lldb::addr_t GetLoadAddress();
 
diff --git a/lldb/source/ValueObject/ValueObject.cpp b/lldb/source/ValueObject/ValueObject.cpp
index 37210055af6e9..51894f718db52 100644
--- a/lldb/source/ValueObject/ValueObject.cpp
+++ b/lldb/source/ValueObject/ValueObject.cpp
@@ -2968,33 +2968,6 @@ lldb::ValueObjectSP ValueObject::Clone(ConstString new_name) {
   return ValueObjectCast::Create(*this, new_name, GetCompilerType());
 }
 
-ValueObjectSP ValueObject::CastPointerType(const char *name,
-                                           CompilerType &compiler_type) {
-  ValueObjectSP valobj_sp;
-  addr_t ptr_value = GetPointerValue().address;
-
-  if (ptr_value != LLDB_INVALID_ADDRESS) {
-    Address ptr_addr(ptr_value);
-    ExecutionContext exe_ctx(GetExecutionContextRef());
-    valobj_sp = ValueObjectMemory::Create(
-        exe_ctx.GetBestExecutionContextScope(), name, ptr_addr, compiler_type);
-  }
-  return valobj_sp;
-}
-
-ValueObjectSP ValueObject::CastPointerType(const char *name, TypeSP &type_sp) {
-  ValueObjectSP valobj_sp;
-  addr_t ptr_value = GetPointerValue().address;
-
-  if (ptr_value != LLDB_INVALID_ADDRESS) {
-    Address ptr_addr(ptr_value);
-    ExecutionContext exe_ctx(GetExecutionContextRef());
-    valobj_sp = ValueObjectMemory::Create(
-        exe_ctx.GetBestExecutionContextScope(), name, ptr_addr, type_sp);
-  }
-  return valobj_sp;
-}
-
 lldb::addr_t ValueObject::GetLoadAddress() {
   if (auto target_sp = GetTargetSP()) {
     const bool scalar_is_load_address = true;

``````````

</details>


https://github.com/llvm/llvm-project/pull/191032