[Lldb-commits] [lldb] 004206a - [lldb-dap] Using an empty target instead of a dummy target. (#189734)

[via lldb-commits]

Author: John Harrison
Date: 2026-04-08T11:09:41-07:00
New Revision: 004206ac5533a1b5296a124e23b0c4638b6ef41e

URL: https://github.com/llvm/llvm-project/commit/004206ac5533a1b5296a124e23b0c4638b6ef41e
DIFF: https://github.com/llvm/llvm-project/commit/004206ac5533a1b5296a124e23b0c4638b6ef41e.diff

LOG: [lldb-dap] Using an empty target instead of a dummy target. (#189734)

Removing the use of the dummy target and instead letting the debugger
instance create the target it needs.

Added: 
    

Modified: 
    lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp b/lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
index a02bb73dd6b3b..9f708e7087e19 100644
--- a/lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
+++ b/lldb/tools/lldb-dap/Handler/AttachRequestHandler.cpp
@@ -72,12 +72,8 @@ Error AttachRequestHandler::Run(const AttachRequestArguments &args) const {
     target = dap.CreateTarget(error);
   }
 
-  // Fallback to the 'dummy' target if we failed to create a real target, so we
-  // can try to attach.
-  if (!target.IsValid())
-    target = dap.debugger.GetDummyTarget();
-
-  dap.SetTarget(target);
+  if (target.IsValid())
+    dap.SetTarget(target);
 
   // Run any pre run LLDB commands the user specified in the launch.json
   if (Error err = dap.RunPreRunCommands())