[Lldb-commits] [lldb] [llvm] [lldb] Use llvm::DWARFExpression::iterator in DWARFExpression::Evaluate (PR #190556)

[Jonas Devlieghere via lldb-commits]

================
@@ -1506,19 +1502,19 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
     // the DWARF expression to skip forward or backward from the current
     // operation, beginning after the 2-byte constant.
     case DW_OP_skip: {
-      int16_t skip_offset = (int16_t)opcodes.GetU16(&offset);
-      lldb::offset_t new_offset = offset + skip_offset;
+      int16_t skip_offset = (int16_t)op->getRawOperand(0);
----------------
JDevlieghere wrote:

We have a lot of C-style casts in this file. Since this is touching a lot of those lines, now might be a good time to fix that. However not in this PR of course. Not a blocker, just a suggestion if you feel up for it. Might be nice to do that first and then land this one instead of the other way around to keep this change in the blame list.

https://github.com/llvm/llvm-project/pull/190556