[Lldb-commits] [lldb] [lldb][NFC] Add helper to compute breakpoint's constituent load address (PR #190762)

[Felipe de Azevedo Piovezan via lldb-commits]

felipepiovezan wrote:

> This looks fine to me. I don't have a strong opinion one way or the other, but why did you do this as a static method in this file rather than a private method on Process? Since you are requiring a valid process to be passed in, it would seem more natural for this to be a method?

The general logic is: if a programmer makes something a _member_ method, they are telling me one of two things:

1) they want expose this method to users of the class, 
2) implementing this method requires access to implementation details (private stuff) of the class 

In this case, neither of those are true

https://github.com/llvm/llvm-project/pull/190762