[Lldb-commits] [lldb] [lldb/Target] Unify frame provider descriptor and chain IDs (PR #190712)

[Med Ismail Bennani via lldb-commits]

================
@@ -3731,12 +3729,25 @@ llvm::Expected<uint32_t> Target::AddScriptedFrameProviderDescriptor(
   {
     std::unique_lock<std::recursive_mutex> guard(
         m_frame_provider_descriptors_mutex);
-    m_frame_provider_descriptors[descriptor_id] = descriptor;
-  }
 
-  InvalidateThreadFrameProviders();
+    // Check for duplicate: same class name and args (content hash).
+    uint32_t descriptor_hash = descriptor.GetHash();
+    for (const auto &entry : m_frame_provider_descriptors) {
+      if (entry.second.GetHash() == descriptor_hash)
+        return llvm::createStringError(
----------------
medismailben wrote:

I agree.

https://github.com/llvm/llvm-project/pull/190712