[Lldb-commits] [lldb] [lldb/Target] Unify frame provider descriptor and chain IDs (PR #190712)

[via lldb-commits]

================
@@ -83,12 +87,20 @@ struct ScriptedFrameProviderDescriptor {
   /// Check if this descriptor has valid metadata for script-based providers.
   bool IsValid() const { return scripted_metadata_sp != nullptr; }
 
-  /// Get a unique identifier for this descriptor based on its contents.
-  /// The ID is computed from the class name and arguments dictionary,
-  /// not from the pointer address, so two descriptors with the same
-  /// contents will have the same ID.
+  /// Get a unique identifier for this descriptor.
+  /// Returns the monotonically increasing ID assigned by Target if set
+  /// (non-zero), otherwise falls back to the content-based hash from
+  /// ScriptedMetadata.
----------------
jimingham wrote:

This worries me.  When am I likely to have to deal with a hash rather than the ID here?  Seems odd that I could ask the question at two different points and get different answers.

https://github.com/llvm/llvm-project/pull/190712