[Lldb-commits] [lldb] [lldb][Darwin] Fetch detailed binary info in chunks (PR #190720)

[via lldb-commits]

================
@@ -203,22 +199,53 @@ void DynamicLoaderMacOS::DoInitialImageFetch() {
   UnloadAllImages();
 
   StructuredData::ObjectSP all_image_info_json_sp(
-      m_process->GetLoadedDynamicLibrariesInfos());
+      m_process->GetLoadedDynamicLibrariesInfos(
+          /*include_mh_and_load_commands=*/false));
   ImageInfo::collection image_infos;
   if (all_image_info_json_sp.get() &&
----------------
jimingham wrote:

If GetLoadedDynamicLibrariesInfos returns something that in not a dictionary or an images list that isn't an array, you might want to emit some kind of error or warning about that.  Someone is going to mysteriously not get shared libraries and if there's some subtle error in the JSON we're going to waste time trying to eye-parse the JSON, when a "Hey, this wasn't a dictionary" would be clear.

https://github.com/llvm/llvm-project/pull/190720