[Lldb-commits] [lldb] [LLDB] Support enabling/disabling InstrumentationRuntime plugins during a debug session (PR #190083)

[Dan Liew via lldb-commits]

================
@@ -2617,6 +2617,20 @@ void PruneThreadPlans();
   lldb::InstrumentationRuntimeSP
   GetInstrumentationRuntime(lldb::InstrumentationRuntimeType type);
 
+  /// Enable/Disable an instrumentation runtime plugin for this process.
+  /// If the plugging doesn't currently exist it will be created.
+  /// This is intended to be used by PluginManager to handle requests from
+  /// the user to enable/disable a instrumentation runtime plugin during a
+  /// debug session.
+  ///
+  /// \param irt - The type of instrumentation runtime plugin
+  /// \param enabled - If true try to enable the plugin, otherwise try to
+  /// disable it.
+  ///
+  /// \return true iff the plugin was successfully enabled/disabled.
----------------
delcypher wrote:

With the change to using `llvm::Error` as the return type the interface is no longer ambiguous so I removed the doxygen comments.

https://github.com/llvm/llvm-project/pull/190083