[Lldb-commits] [lldb] [lldb/test] Remove stale Windows expectedFailure decorators (NFC) (PR #190855)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Med Ismail Bennani (medismailben)

<details>
<summary>Changes</summary>

This patch removes stale Windows expectedFailure decorators from TestFrameProviderPassThroughPrefix.py

https://lab.llvm.org/buildbot/#/builders/141/builds/17091

---
Full diff: https://github.com/llvm/llvm-project/pull/190855.diff


1 Files Affected:

- (modified) lldb/test/API/functionalities/scripted_frame_provider/pass_through_prefix/TestFrameProviderPassThroughPrefix.py (-9) 


``````````diff
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/pass_through_prefix/TestFrameProviderPassThroughPrefix.py b/lldb/test/API/functionalities/scripted_frame_provider/pass_through_prefix/TestFrameProviderPassThroughPrefix.py
index 071a7382dcab9..5504a919c2c5f 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/pass_through_prefix/TestFrameProviderPassThroughPrefix.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/pass_through_prefix/TestFrameProviderPassThroughPrefix.py
@@ -89,7 +89,6 @@ def test_pass_through_with_prefix(self):
                 f"Frame {i} should be '{expected}' after provider",
             )
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_shows_unwinder_frames(self):
         """
         Test that 'bt --provider 0' shows the base unwinder frames
@@ -123,7 +122,6 @@ def test_bt_provider_shows_unwinder_frames(self):
         self.assertIn("baz", output)
         self.assertNotIn("my_custom_", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_shows_provider_frames(self):
         """
         Test that 'bt --provider <id>' shows the provider's transformed frames
@@ -165,7 +163,6 @@ def test_bt_provider_shows_provider_frames(self):
         self.assertIn("my_custom_foo", output)
         self.assertIn("my_custom_main", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_range(self):
         """
         Test that 'bt --provider 0-<id>' shows both the base unwinder
@@ -205,7 +202,6 @@ def test_bt_provider_range(self):
         self.assertIn("Base Unwinder", output)
         self.assertIn("PrefixPassThroughProvider", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_range_not_starting_at_zero(self):
         """
         Test that 'bt --provider <id>-<id>' works when the range doesn't
@@ -246,7 +242,6 @@ def test_bt_provider_range_not_starting_at_zero(self):
         self.assertIn("PrefixPassThroughProvider", output)
         self.assertIn("my_custom_baz", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_range_with_to_separator(self):
         """
         Test that 'bt --provider 0 to <id>' works with the 'to' separator.
@@ -315,7 +310,6 @@ def test_bt_provider_invalid_range(self):
         self.assertFalse(result.Succeeded(), "bt --provider 5-2 should fail")
         self.assertIn("invalid provider range", result.GetError())
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_star_shows_all(self):
         """
         Test that 'bt --provider *' shows all providers including the
@@ -345,7 +339,6 @@ def test_bt_provider_star_shows_all(self):
         self.assertIn("Base Unwinder", output)
         self.assertIn("PrefixPassThroughProvider", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_all_shows_all(self):
         """
         Test that 'bt --provider all' shows all providers including the
@@ -383,7 +376,6 @@ def test_bt_provider_all_shows_all(self):
         self.assertIn("PrefixPassThroughProvider", output)
         self.assertIn("UpperCasePassThroughProvider", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_multiple_providers(self):
         """
         Test 'bt --provider' with two chained providers. Register
@@ -436,7 +428,6 @@ def test_bt_provider_multiple_providers(self):
         # outermost output should have fully upper-cased prefixed names.
         self.assertIn("MY_CUSTOM_BAZ", output)
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
     def test_bt_provider_star_from_within_provider(self):
         """
         Test that running 'bt --provider *' re-entrantly from within a

``````````

</details>


https://github.com/llvm/llvm-project/pull/190855