[Lldb-commits] [lldb] [lldb] Upstream and adopt ReadUnsignedIntegersFromMemory in AppleObjCRuntimeV2 (PR #190564)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -69,6 +70,30 @@
 using namespace lldb;
 using namespace lldb_private;
 
+namespace {
+struct RuntimeGlobalSymbolSpec {
+  ConstString name;
+
+  /// Whether to only return the address or also the value.
+  bool read_value = true;
+
+  /// A byte size of 0 means use the process pointer size.
+  uint8_t byte_size = 0;
+
+  uint64_t default_value = LLDB_INVALID_ADDRESS;
+
+  lldb::SymbolType sym_type = lldb::eSymbolTypeData;
+};
+
+struct RuntimeGlobalSymbolResult {
+  uint64_t value = 0;
+  bool success = false;
+};
+
+/// Constant used for SmallVector.
+static constexpr uint8_t kMaxResults = 12;
----------------
felipepiovezan wrote:

Personally I would remove this and just use the default. The name is very misleading: there is nothing about this value that limits the number of results

https://github.com/llvm/llvm-project/pull/190564