[Lldb-commits] [lldb] [lldb][Darwin] Fetch detailed binary info in chunks (PR #190720)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

I'm doing one thing in `DynamicLoaderMacOS::AddBinaries` that is questionable -- I call ModulesDidLoad (via `DynamicLoaderDarwin::AddModulesUsingPreloadedModules()`) for each chunk of binaries we retrieve.  I think a broadcast message might go to the driver (if it signed up for it) whenever binaries are loaded, so now it might get 2 or 3 separate notifications about libraries being loaded at a single stop.  

It would be possible to change `DynamicLoaderDarwin::JSONImageInformationIntoImageInfo` from "fill in an empty std::vector<ImageInfo>" to "add new entries to a possibly-populated std::vector<ImageInfo>" and maintain the one-broadcast-message (one ModulesDidLoad) per binary-loaded stop.

https://github.com/llvm/llvm-project/pull/190720