[Lldb-commits] [lldb] [llvm] [lldb] Use llvm::DWARFExpression::iterator in DWARFExpression::Evaluate (PR #190556)

[Sergei Barannikov via lldb-commits]

================
@@ -1759,12 +1755,12 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
     case DW_OP_breg29:
     case DW_OP_breg30:
     case DW_OP_breg31: {
-      reg_num = op - DW_OP_breg0;
+      reg_num = opcode - DW_OP_breg0;
       if (llvm::Error err =
               ReadRegisterValueAsScalar(reg_ctx, reg_kind, reg_num, tmp))
         return err;
 
-      int64_t breg_offset = opcodes.GetSLEB128(&offset);
+      int64_t breg_offset = op->getRawOperand(0);
----------------
s-barannikov wrote:

I was confused by this comment because `reg_num = opcode - DW_OP_breg0` here, but then I realized it was supposed to be a little down below. Thanks for spotting

https://github.com/llvm/llvm-project/pull/190556