jimingham wrote: LGTM except it would be good if you can come up with a comment saying what this solved. Somebody got it wrong before you so it wasn't 100% obvious... https://github.com/llvm/llvm-project/pull/190409