[Lldb-commits] [clang] [lldb] [clang] DeducedTypes deduction kind fix and improvement (PR #186727)
Matheus Izvekov via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 3 09:53:26 PDT 2026
mizvekov wrote:
> It is very hard to tell if this is really properly tested. It does not feel like it based on the changes and the number of new tests added. IF you could spend some time writing tests to make sure we are covering all the new code that would be helpful.
These are all mostly NFC-ish changes to a feature that is extensively tested.
> I also feel like you should have waited to get review from both LLDB and ASTImporter folks, I added some folks from these areas.
I disagree, this is a fairly straight-forward change.
https://github.com/llvm/llvm-project/pull/186727
More information about the lldb-commits
mailing list