[Lldb-commits] [lldb] [llvm] [lldb] Load scripts from code signed dSYM bundles (PR #189444)

[Jonas Devlieghere via lldb-commits]

================
@@ -1467,16 +1467,22 @@ bool Module::LoadScriptingResourceInTarget(Target *target, Status &error) {
     debugger.ReportWarning(feedback_stream.GetString().str(), debugger.GetID());
 
   for (const auto &[scripting_fspec, load_style] : file_specs) {
-    if (load_style == eLoadScriptFromSymFileFalse)
-      continue;
-
     if (!FileSystem::Instance().Exists(scripting_fspec))
       continue;
 
-    if (load_style == eLoadScriptFromSymFileWarn) {
-      // clang-format off
+    switch (load_style) {
+    case eLoadScriptFromSymFileFalse:
+      continue;
+    case eLoadScriptFromSymFileTrue:
+      break;
+    case eLoadScriptFromSymFileTrusted:
+      if (!platform_sp->IsSymbolFileTrusted(*this))
+        continue;
----------------
JDevlieghere wrote:

Yeah, that was Jim's suggestion that became (4) in https://github.com/llvm/llvm-project/pull/189444#issuecomment-4165226875 

https://github.com/llvm/llvm-project/pull/189444