https://github.com/DavidSpickett commented: LGTM assuming you address my comment(s) and remove the formatting changes that aren't in your new code. If the CI formatter complains about anything else, ignore it. https://github.com/llvm/llvm-project/pull/190173