[Lldb-commits] [lldb] [lldb] Skip local variable declarations at start of Wasm function (PR #190093)

[David Spickett via lldb-commits]

================
@@ -365,13 +389,20 @@ ParseFunctions(DataExtractor &data) {
   functions.reserve(*function_count);
 
   for (uint32_t i = 0; i < *function_count; ++i) {
-    llvm::Expected<uint32_t> function_size = GetULEB32(data, offset);
-    if (!function_size)
-      return function_size.takeError();
     // llvm-objdump considers the ULEB with the function size to be part of the
     // function. We can't do that here because that would break symbolic
     // breakpoints, as that address is never executed.
----------------
DavidSpickett wrote:

Does this comment need to be updated?

We are in an in between area now aren't we. We consider the locals to be part of the fuction but the first place you can place a breakpoint is just beyond them.

I think it's the "address is never executed" part that needs adjusting. It is true but the locals are also not executed, right? Or are they executed by the runtime automatically or something like that.

https://github.com/llvm/llvm-project/pull/190093