[Lldb-commits] [lldb] [lldb] Fix DIL error diagnostics output (PR #187680)

[Michael Buch via lldb-commits]

================
@@ -552,7 +552,9 @@ ValueObjectSP StackFrame::DILGetValueForVariableExpressionPath(
   auto lex_or_err = dil::DILLexer::Create(var_expr, mode);
   if (!lex_or_err) {
     error = Status::FromError(lex_or_err.takeError());
-    return ValueObjectConstResult::Create(nullptr, std::move(error));
+    // Duplicate the error so that it can be accessed from both
----------------
Michael137 wrote:

Probably don't need the comment (if we're not also commenting in all the other places). TBH the previous `move` just seems like a bug. If we wanted to move the error we should've made it a `Error *` output argument and set it to null. But this seems better

https://github.com/llvm/llvm-project/pull/187680