[Lldb-commits] [lldb] [lldb] Standardize TestVectorOfEnums.py as a C++ data formatter test (PR #189757)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

<details>
<summary>Changes</summary>

This is explicitly marked as a libc++ test and functionally tests the formatter for a vector of enums. I put it in the generic directory because there's no reason this couldn't work for other c++ stdlibs.

Additionally, this should be using the custom libc++ like the other tests.

---
Full diff: https://github.com/llvm/llvm-project/pull/189757.diff


3 Files Affected:

- (renamed) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/Makefile () 
- (renamed) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/TestVectorOfEnums.py (+1-2) 
- (renamed) lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/main.cpp () 


``````````diff
diff --git a/lldb/test/API/commands/expression/vector_of_enums/Makefile b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/Makefile
similarity index 100%
rename from lldb/test/API/commands/expression/vector_of_enums/Makefile
rename to lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/Makefile
diff --git a/lldb/test/API/commands/expression/vector_of_enums/TestVectorOfEnums.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/TestVectorOfEnums.py
similarity index 92%
rename from lldb/test/API/commands/expression/vector_of_enums/TestVectorOfEnums.py
rename to lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/TestVectorOfEnums.py
index 8580cadac3e25..0d885a555652c 100644
--- a/lldb/test/API/commands/expression/vector_of_enums/TestVectorOfEnums.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/TestVectorOfEnums.py
@@ -3,7 +3,6 @@
 correctly, in this case specifically std::vector of enums.
 """
 
-
 import lldb
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
@@ -13,7 +12,7 @@
 class TestVectorOfEnums(TestBase):
     @add_test_categories(["libc++"])
     def test_vector_of_enums(self):
-        self.build()
+        self.build(dictionary={"USE_LIBCPP": 1})
 
         lldbutil.run_to_source_breakpoint(
             self, "// break here", lldb.SBFileSpec("main.cpp", False)
diff --git a/lldb/test/API/commands/expression/vector_of_enums/main.cpp b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/main.cpp
similarity index 100%
rename from lldb/test/API/commands/expression/vector_of_enums/main.cpp
rename to lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector_of_enums/main.cpp

``````````

</details>


https://github.com/llvm/llvm-project/pull/189757