[Lldb-commits] [lldb] [lldb][Platform] Handle LoadScriptFromSymFile per-module FileSpec (PR #189696)

[via lldb-commits]

================
@@ -248,17 +250,19 @@ FileSpecList PlatformDarwin::LocateExecutableScriptingResourcesFromDSYM(
     module_spec.SetFilename(filename_no_extension);
   }
 
-  return file_list;
+  return file_specs;
 }
 
-FileSpecList PlatformDarwin::LocateExecutableScriptingResourcesForPlatform(
+llvm::SmallDenseMap<FileSpec, LoadScriptFromSymFile>
+PlatformDarwin::LocateExecutableScriptingResourcesForPlatform(
     Target *target, Module &module, Stream &feedback_stream) {
+  llvm::SmallDenseMap<FileSpec, LoadScriptFromSymFile> file_specs;
----------------
jimingham wrote:

Ah, that's unfortunate.  If you were intending to only use this for the empty return and not accumulate into it, then naming it something like `empty_specs` would make the intent clearer.  But that's make-work if you are going to end up using it.

https://github.com/llvm/llvm-project/pull/189696