[Lldb-commits] [lldb] [lldb] Remove Address::SetRawAddress(), use equivalent constructor (NFC) (PR #189095)

[Jason Molenda via lldb-commits]

https://github.com/jasonmolenda requested changes to this pull request.

No, this is a dangerous change.  Having a constructor that takes `Address(deref_addr)` is going to be _very_ tempting for people to accidentally use, when they really want to pass a load address (`addr_t`) and a `Target` so the Address object can be set in terms of a Section + offset.

The number of cases where you are explicitly avoiding the resolution of a breakpoint to Section+offset is minuscule -- five uses across the codebase today? -- and it is something that people should have to use a special method to create.

https://github.com/llvm/llvm-project/pull/189095