[Lldb-commits] [lldb] [lldb-dap][windows] add integratedTerminal and externalTerminal support (PR #174635)

[Charles Zablit via lldb-commits]

================
@@ -118,7 +118,8 @@ RunInTerminal(DAP &dap, const protocol::LaunchRequestArguments &arguments) {
       arguments.console == protocol::eConsoleExternalTerminal);
   dap.SendReverseRequest<LogFailureResponseHandler>("runInTerminal",
                                                     std::move(reverse_request));
-
+  comm_file
+      ->Connect(); // we need to wait for the client to connect to the pipe.
----------------
charles-zablit wrote:

Fixed, thanks!

https://github.com/llvm/llvm-project/pull/174635