[Lldb-commits] [lldb] [LLDB] Use shared_ptr for m_current_private_state_thread (PR #188542)

[Anshul Nigham via lldb-commits]

nigham wrote:

> I don't want to leave the code the way you have written it here, because it would be easy for someone to come along later and move code around and lose one of the PrivateStateThread objects.
> 
> Doing what I suggested is also a non-functional change since it just moves an operation we're already doing closer to where it matters. It is in fact less of a behavior change than changing the memory management strategy for an entity in lldb. So I don't see the force of that argument.
> 
> If you need to do this as a separate commit for some reason of your own, please implement the change I suggested as a stacked PR and then we can accept the two of them together.

Done in the current PR. PTAL.

https://github.com/llvm/llvm-project/pull/188542