[Lldb-commits] [lldb] [lldb][Process/FreeBSDKernelCore] Always reconstruct thread list for kvm (PR #188395)

Minsoo Choo via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 25 05:51:43 PDT 2026


https://github.com/mchoo7 updated https://github.com/llvm/llvm-project/pull/188395

>From 37a009854ddd8fd5995cb17006023cfdcf399621 Mon Sep 17 00:00:00 2001
From: Minsoo Choo <minsoochoo0122 at proton.me>
Date: Wed, 25 Mar 2026 10:30:36 +0900
Subject: [PATCH 1/2] [lldb][Process/FreeBSDKernelCore] Always reconstruct
 thread list for kvm

Signed-off-by: Minsoo Choo <minsoochoo0122 at proton.me>
---
 .../FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp      | 8 +++++---
 .../FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.h        | 4 +++-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index d1a4a1ebc47d7..e969bfc5ac7f7 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -64,7 +64,8 @@ ProcessFreeBSDKernelCore::ProcessFreeBSDKernelCore(lldb::TargetSP target_sp,
                                                    ListenerSP listener_sp,
                                                    kvm_t *kvm,
                                                    const FileSpec &core_file)
-    : PostMortemProcess(target_sp, listener_sp, core_file), m_kvm(kvm) {}
+    : PostMortemProcess(target_sp, listener_sp, core_file), m_is_kvm(true),
+      m_kvm(kvm) {}
 
 ProcessFreeBSDKernelCore::~ProcessFreeBSDKernelCore() {
   if (m_kvm)
@@ -157,9 +158,10 @@ size_t ProcessFreeBSDKernelCore::DoWriteMemory(lldb::addr_t addr,
 
 bool ProcessFreeBSDKernelCore::DoUpdateThreadList(ThreadList &old_thread_list,
                                                   ThreadList &new_thread_list) {
-  if (old_thread_list.GetSize(false) == 0) {
+  if (m_is_kvm || old_thread_list.GetSize(false) == 0) {
     // Make up the thread the first time this is called so we can set our one
-    // and only core thread state up.
+    // and only core thread state up. Since target type (crash dump or live
+    // memory) isn't identifable in kvm, always reconstruct thread list for kvm.
 
     // We cannot construct a thread without a register context as that crashes
     // LLDB but we can construct a process without threads to provide minimal
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.h b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.h
index d82e55ea74bd9..1e9be0ae94c7f 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.h
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.h
@@ -70,9 +70,11 @@ class ProcessFreeBSDKernelCore : public lldb_private::PostMortemProcess {
 
   const char *GetError();
 
-  bool m_printed_unread_message = false;
+  const bool m_is_kvm;
 
   kvm_t *m_kvm;
+
+  bool m_printed_unread_message = false;
 };
 
 #endif // LLDB_SOURCE_PLUGINS_PROCESS_FREEBSDKERNEL_PROCESSFREEBSDKERNELCORE_H

>From 30ff3c7d26ed3dc2f824032e11036b359953075e Mon Sep 17 00:00:00 2001
From: Minsoo Choo <minsoochoo0122 at proton.me>
Date: Wed, 25 Mar 2026 21:49:17 +0900
Subject: [PATCH 2/2] fixup! [lldb][Process/FreeBSDKernelCore] Always
 reconstruct thread list for kvm

Signed-off-by: Minsoo Choo <minsoochoo0122 at proton.me>
---
 lldb/include/lldb/Target/Process.h                            | 2 ++
 .../Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp  | 4 ++--
 lldb/source/Target/Process.cpp                                | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h
index e3ce5cd7c16ee..b0ea84672d470 100644
--- a/lldb/include/lldb/Target/Process.h
+++ b/lldb/include/lldb/Target/Process.h
@@ -3381,6 +3381,8 @@ void PruneThreadPlans();
                             ///see them. This is usually the same as
   ///< m_thread_list_real, but might be different if there is an OS plug-in
   ///creating memory threads
+  bool m_always_update_thread_list = false; ///< Always run UpdateThreadList()
+                                            /// in UpdateThreadListIfNeeded()
   ThreadPlanStackMap m_thread_plans; ///< This is the list of thread plans for
                                      /// threads in m_thread_list, as well as
                                      /// threads we knew existed, but haven't
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index e969bfc5ac7f7..72cf8bbf730fd 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -64,8 +64,8 @@ ProcessFreeBSDKernelCore::ProcessFreeBSDKernelCore(lldb::TargetSP target_sp,
                                                    ListenerSP listener_sp,
                                                    kvm_t *kvm,
                                                    const FileSpec &core_file)
-    : PostMortemProcess(target_sp, listener_sp, core_file), m_is_kvm(true),
-      m_kvm(kvm) {}
+    : PostMortemProcess(target_sp, listener_sp, core_file),
+      m_always_update_thread_list(true), m_is_kvm(true), m_kvm(kvm) {}
 
 ProcessFreeBSDKernelCore::~ProcessFreeBSDKernelCore() {
   if (m_kvm)
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 587d9f6408ae4..5f07935c1a59b 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -1102,7 +1102,7 @@ bool Process::UpdateThreadList(ThreadList &old_thread_list,
 
 void Process::UpdateThreadListIfNeeded() {
   const uint32_t stop_id = GetStopID();
-  if (m_thread_list.GetSize(false) == 0 ||
+  if (m_always_update_thread_list || m_thread_list.GetSize(false) == 0 ||
       stop_id != m_thread_list.GetStopID()) {
     bool clear_unused_threads = true;
     const StateType state = GetPrivateState();



More information about the lldb-commits mailing list