[Lldb-commits] [lldb] [lldb][Process/FreeBSDKernelCore] Rework plugin destruction (PR #188426)

Minsoo Choo via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 25 00:42:44 PDT 2026


https://github.com/mchoo7 created https://github.com/llvm/llvm-project/pull/188426

Destroy the plugin classes similar to `ProcessElfCore`, another process plugin derived from `PostMortemProcess` class. After clearing thread list, invoke `Finalize()` to cleanup resources properly. `Finalize()` will call `DoDestroy()` which releases `m_kvm` via `kvm_close()`.

>From e199a46221daa0c5874205c18d8cd876f0bf6573 Mon Sep 17 00:00:00 2001
From: Minsoo Choo <minsoochoo0122 at proton.me>
Date: Wed, 25 Mar 2026 16:05:54 +0900
Subject: [PATCH] [lldb][Process/FreeBSDKernelCore] Rework plugin destruction

Signed-off-by: Minsoo Choo <minsoochoo0122 at proton.me>
---
 .../ProcessFreeBSDKernelCore.cpp                | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index da8e22caaa80f..1dbf35f660806 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -67,8 +67,13 @@ ProcessFreeBSDKernelCore::ProcessFreeBSDKernelCore(lldb::TargetSP target_sp,
     : PostMortemProcess(target_sp, listener_sp, core_file), m_kvm(kvm) {}
 
 ProcessFreeBSDKernelCore::~ProcessFreeBSDKernelCore() {
-  if (m_kvm)
-    kvm_close(m_kvm);
+  m_thread_list.Clear();
+
+  // We need to call finalize on the process before destroying ourselves to
+  // make sure all of the broadcaster cleanup goes as planned. If we destruct
+  // this class, then Process::~Process() might have problems trying to fully
+  // destroy the broadcaster.
+  Finalize(true /* destructing */);
 }
 
 lldb::ProcessSP ProcessFreeBSDKernelCore::CreateInstance(
@@ -126,7 +131,13 @@ DynamicLoader *ProcessFreeBSDKernelCore::GetDynamicLoader() {
   return m_dyld_up.get();
 }
 
-Status ProcessFreeBSDKernelCore::DoDestroy() { return Status(); }
+Status ProcessFreeBSDKernelCore::DoDestroy() {
+  if (!m_kvm)
+    return Status::FromErrorString("kvm file descriptor is not set.");
+
+  kvm_close(m_kvm);
+  return Status();
+}
 
 void ProcessFreeBSDKernelCore::RefreshStateAfterStop() {
   if (!m_printed_unread_message) {



More information about the lldb-commits mailing list